Stream: git-wasmtime

Topic: wasmtime / Issue #1836 Cranelift: Module data apis should...

Wasmtime GitHub notifications bot (Jun 06 2020 at 14:31):

github-actions[bot] commented on Issue #1836:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:module"

Thus the following users have been cc'd because of the following labels:

• bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 06 2020 at 14:35):

bjorn3 commented on Issue #1836:

Please add an assertion to cranelift-faerie that section is None. You don't have to implement support, as it has been deprecated.

Wasmtime GitHub notifications bot (Jun 08 2020 at 06:52):

carlokok commented on Issue #1836:

Please add an assertion to cranelift-faerie that section is None. You don't have to implement support, as it has been deprecated.

Looking at the build failure, should I do something for JIT too ?

Wasmtime GitHub notifications bot (Jun 08 2020 at 08:45):

bjorn3 commented on Issue #1836:

For simplejit I think an assertion would be fine too.

Wasmtime GitHub notifications bot (Jun 08 2020 at 18:01):

carlokok commented on Issue #1836:

pushed a fix for fmt & simplejit. Never did rust before today so sorry for the long number of commits.

Wasmtime GitHub notifications bot (Jun 15 2020 at 18:47):

carlokok commented on Issue #1836:

I think I addressed all your concerns now.

Wasmtime GitHub notifications bot (Jun 15 2020 at 20:46):

pchickey commented on Issue #1836:

Thanks! Looks great. One last thing required to merge - can you please run cargo fmt at the root of the project to get the rustfmt CI check to pass? rustup component add rustfmt will install that command if you don't have it.

Wasmtime GitHub notifications bot (Jun 17 2020 at 17:49):

pchickey commented on Issue #1836:

Thank you!

Last updated: Dec 23 2024 at 12:05 UTC