Wasmtime GitHub notifications bot (Jun 04 2020 at 22:55): Wasmtime GitHub notifications bot (Jun 04 2020 at 22:55):github-actions[bot] commented on Issue #1824:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Jun 08 2020 at 22:02):fitzgen commented on Issue #1824:
The different stack slots are hard to reason about because their offsets refer to different bases. The offset of an OutgoingArg is from the stack pointer of the caller, while all the rest are from the callee [1]. My best guess would be that some confusion is happening there.
This does sound like a likely place for a bug to sneak in.
I'm going to go ahead and remove the failing test and land the doc updates + other new tests in the mean time.
Wasmtime GitHub notifications bot (Jun 08 2020 at 22:02):fitzgen commented on Issue #1824:
Thanks for taking a look!
Last updated: Dec 23 2024 at 12:05 UTC