Stream: git-wasmtime

Topic: wasmtime / Issue #1811 Fix build warnings (errors on CI) ...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 16:40):

abrown commented on Issue #1811:

This is duplicated in #1807... only one should be merged.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 16:49):

cfallin commented on Issue #1811:

D'oh, I missed @sunfishcode 's PR -- sorry for the duplication. Looks like #1807 has been sitting for a few hours though so I'll go ahead and merge this if the CI passes (with the unit-test fixes I just pushed too)...

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 17:00):

github-actions[bot] commented on Issue #1811:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:module"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 17:09):

cfallin commented on Issue #1811:

Hmm, this seems to go deeper than just the warnings -- error from tests: test debug::lldb::test_debug_dwarf_ptr ... FAILED

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 17:18):

cfallin commented on Issue #1811:

@yurydelendik I think you might have some insights on the DWARF test failures?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 18:14):

cfallin commented on Issue #1811:

I've spent a bit of time poking at the lldb test failure; it works fine locally; looking at the filecheck output, it seems that the output is just cut off prematurely when run on CI. Maybe a race condition of some sort? Or a hidden crash? Worth noting I'm testing with LLVM/LLDB 10.0, while the test instance seems to use version 9.0.

In any case, would it make sense to disable the failing test (and create an issue) since it's on master already and is blocking other PRs?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 18:28):

alexcrichton commented on Issue #1811:

Personally I think it's fine to disable the test and file an issue. The underlying issue seems to be the update to the lock file in https://github.com/bytecodealliance/wasmtime/pull/1805, so it may also be best to roll back the updates there (except for our own version bumps) and see if that fixes the issue. It could indicate a bug in one of our dependencies.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 19:10):

cfallin commented on Issue #1811:

@yurydelendik found that freezing region at an older version fixes the issue in #1812 -- IMHO we should take that and then make these changes and debug the LLDB test later under less pressure when we unfreeze.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 03 2020 at 19:13):

yurydelendik commented on Issue #1811:

found that freezing region at an older version fixes the is

actually it is backtrace or gimli -- I pushed freezing of backtrace to specific version

Last updated: Dec 23 2024 at 12:05 UTC