Stream: git-wasmtime

Topic: wasmtime / Issue #1808 impl WasmTy for u32 and u64

Wasmtime GitHub notifications bot (Jun 03 2020 at 15:24):

github-actions[bot] commented on Issue #1808:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 03 2020 at 15:30):

alexcrichton commented on Issue #1808:

Agreed these are good to have, thanks!

Some other items I think to take care of are:

• Could these be written in terms of the i32/i64 impls to cut down on duplication?
• Can documentation be added to Func::wrap about these types?
• Can tests be added which exercise the presence of these impls?

Wasmtime GitHub notifications bot (Jun 03 2020 at 21:20):

leoyvens commented on Issue #1808:

@alexcrichton thanks for the review, I've addressed all points.

Wasmtime GitHub notifications bot (Jun 03 2020 at 21:33):

alexcrichton commented on Issue #1808:

Looks great to me! As one final nit, there's a table under "Rust types will map to WebAssembly types as follows", mind adding the u32/u64 types there too?

Wasmtime GitHub notifications bot (Jun 03 2020 at 21:56):

leoyvens commented on Issue #1808:

@alexcrichton ah of course, I missed that. Updated it.

Wasmtime GitHub notifications bot (Jun 04 2020 at 14:00):

alexcrichton commented on Issue #1808:

:+1:

Last updated: Nov 22 2024 at 16:03 UTC