Stream: git-wasmtime

Topic: wasmtime / Issue #1796 wiggle: switch logging to use `tra...

Wasmtime GitHub notifications bot (Jun 03 2020 at 18:01):

pchickey edited a comment on Issue #1796:

I believe this is ready for review. During development I switched the design a fair bit, but I think the current one is reasonable for now. The tracing dep taken on by wasmtime is small enough that it should be ok, and @fitzgen plans to use tracing throughout cranelift and wasmtime soon.

Tracing can't be disabled at the moment. In the future, Nick plans to introduce tracing_noop crate in the cranelift tree so that spidermonkey doesn't have to vendor in the tracing ecosystem (they're particularly sensitive about vendoring deps, for good reason), and we can use that as a way to disable tracing in this crate once this lands. I don't think disabling it is worth blocking this change for now.

The example program at crates/wiggle/test-helpers/examples/tracing.rs demonstrates the use of tracing-subscriber and log as backends to the tracing statements emitted by wiggle. If you set the RUST_LOG environment variable, itll use env_logger to output, otherwise it'll use tracing-subscriber.

Wasmtime GitHub notifications bot (Jun 03 2020 at 18:01):

pchickey edited a comment on Issue #1796:

I believe this is ready for review. During development I switched the design a fair bit, but I think the current one is reasonable for now. The tracing dep taken on by wasmtime is small enough that it should be ok, and @fitzgen plans to use tracing throughout cranelift and wasmtime soon.

Tracing can't be disabled at the moment. In the future, Nick plans to introduce tracing_noop crate in the cranelift tree so that spidermonkey doesn't have to vendor in the tracing ecosystem (they're particularly sensitive about vendoring deps, for good reason), and we can use that as a way to disable tracing in this crate once this lands. I don't think the inability to disable tracing is worth blocking this change for now.

The example program at crates/wiggle/test-helpers/examples/tracing.rs demonstrates the use of tracing-subscriber and log as backends to the tracing statements emitted by wiggle. If you set the RUST_LOG environment variable, itll use env_logger to output, otherwise it'll use tracing-subscriber.

Wasmtime GitHub notifications bot (Jun 04 2020 at 16:44):

pchickey commented on Issue #1796:

Thanks everyone, I appreciate all of the help and discussion we had on getting this right.

Last updated: Oct 23 2024 at 20:03 UTC