Stream: git-wasmtime

Topic: wasmtime / Issue #1790 wiggle: allow user-configurable er...

view this post on Zulip Wasmtime GitHub notifications bot (May 29 2020 at 20:10):

github-actions[bot] commented on Issue #1790:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2020 at 18:26):

pchickey commented on Issue #1790:

Sure, I'll add a test case with multiple error mappings, that seems like a great thing to test.

If you're going to have multiple rich error types mapped to a single abi type, I think the way to do that would be to make your own sum type of the rich errors and let Into do the work. This wont lose information like the way the conversion down to the abi error type does. Something like

pub enum RichestErrorType {
  Foo(#[from] FooErrorType),
  Bar(#[from] BarErrorType),
}

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2020 at 21:11):

pchickey commented on Issue #1790:

I merged in master to pick up #1793 and use the wonderful new witx_literal syntax for the tests (thank you @katie-martin-fastly!), made sure we execute the error conversion code and see that it hooks stuff up right and doesn't panic in the simple test, and added a second more complex test that I think is sufficient to just type-check.

Not gonna touch any of those bikeshed issues until they make a difference in real code.

Last updated: Nov 22 2024 at 16:03 UTC