Wasmtime GitHub notifications bot (May 29 2020 at 17:19): Wasmtime GitHub notifications bot (May 29 2020 at 17:19):whitequark commented on Issue #1788:
cc @iximeow
Wasmtime GitHub notifications bot (May 29 2020 at 17:41):github-actions[bot] commented on Issue #1788:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 29 2020 at 19:07):whitequark commented on Issue #1788:
No logs for failed builds?..
Wasmtime GitHub notifications bot (May 29 2020 at 20:34):tschneidereit commented on Issue #1788:
No logs for failed builds?..
Yeah, something's wrong here. I just retriggered the tests in the hope that this was an intermittent infra issue.
Wasmtime GitHub notifications bot (May 30 2020 at 04:43):whitequark commented on Issue #1788:
I just retriggered the tests in the hope that this was an intermittent infra issue.
I think that broke again, though less severely.
Wasmtime GitHub notifications bot (May 30 2020 at 05:07):iximeow commented on Issue #1788:
I tried rerunning again (because why not) only to see the same mac builds fail. Still no logs or indication of how to acquire them..
Wasmtime GitHub notifications bot (May 30 2020 at 09:50):tschneidereit commented on Issue #1788:
Just tried again, because indeed: why not, but no change. Given that
- the failures are all on macOS, yet this PR doesn't do anything macOS specific
- the failures happen well before anything this PR changes comes into play
- we've since had multiple successful runs in other PRs
I wonder if something's just borked about this PR.@whitequark would you be up for opening a fresh PR for these changes? :fingers_crossed:that makes it go away.
Wasmtime GitHub notifications bot (May 30 2020 at 09:51):tschneidereit edited a comment on Issue #1788:
Just tried again, because indeed: why not, but no change. Given that
- the failures are all on macOS, yet this PR doesn't do anything macOS specific
- the failures happen well before anything this PR changes comes into play
- we've since had multiple successful runs in other PRs
I wonder if something's just borked about this PR.
@whitequark would you be up for opening a fresh PR for these changes? :fingers_crossed:that makes it go away.
Wasmtime GitHub notifications bot (May 30 2020 at 10:26):whitequark commented on Issue #1788:
@tschneidereit https://github.com/bytecodealliance/wasmtime/pull/1794
Wasmtime GitHub notifications bot (May 30 2020 at 10:58):tschneidereit commented on Issue #1788:
@whitequark thank you! Given that #1794 worked, would it make sense to close this and open a new PR with identical patches? It seems implausible that the difference in code chances between this PR and #1794 would translate into this difference in CI success.
Wasmtime GitHub notifications bot (May 30 2020 at 11:59):whitequark commented on Issue #1788:
Given that #1794 worked, would it make sense to close this and open a new PR with identical patches? It seems implausible that the difference in code chances between this PR and #1794 would translate into this difference in CI success.
Er, sorry, I actually made a mistake here--I pushed a wrong branch. Let me do the right thing...
Wasmtime GitHub notifications bot (May 30 2020 at 12:01):whitequark commented on Issue #1788:
Last updated: Dec 23 2024 at 12:05 UTC