Stream: git-wasmtime

Topic: wasmtime / Issue #1787 cranelift: add i64.{ishl,ushr,ashr...

view this post on Zulip Wasmtime GitHub notifications bot (May 29 2020 at 15:57):

whitequark commented on Issue #1787:

cc @iximeow

view this post on Zulip Wasmtime GitHub notifications bot (May 29 2020 at 16:40):

github-actions[bot] commented on Issue #1787:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:module"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 30 2020 at 05:35):

whitequark commented on Issue #1787:

Looks like this PR depends on #1759.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 01:41):

whitequark commented on Issue #1787:

@abrown I rebased the PR on master. I think some checks are failing because of unrelated issues.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 17:02):

abrown commented on Issue #1787:

That's annoying; do you mind opening an issue for it? Looks like something to do with lightbeam and staticvec from this and this

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 21:23):

whitequark commented on Issue #1787:

That's annoying; do you mind opening an issue for it?

I'm confused, isn't master supposed to be always green?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 21:52):

iximeow commented on Issue #1787:

Yes, but some tasks are nightly, with a recent nightly change invalidating what was otherwise fine. https://github.com/bytecodealliance/wasmtime/pull/1818 appears to fix this, try a rebase?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 21:53):

iximeow edited a comment on Issue #1787:

Yes, but some tasks are nightly, with a recent nightly change invalidating what was otherwise fine. https://github.com/bytecodealliance/wasmtime/pull/1818 appears to fix this, try a rebase?

edit: lol, I see your most recent changes were also a rebase. "keep rebasing until it works" :grin:

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 21:57):

whitequark commented on Issue #1787:

Rebased

view this post on Zulip Wasmtime GitHub notifications bot (Jun 04 2020 at 22:30):

whitequark commented on Issue #1787:

Looks like it's green now!

view this post on Zulip Wasmtime GitHub notifications bot (Jun 06 2020 at 02:31):

whitequark commented on Issue #1787:

Thanks!

Last updated: Oct 23 2024 at 20:03 UTC