wasmtime / Issue #1781 Initial, partial support for `exte... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / Issue #1781 Initial, partial support for `exte...

Wasmtime GitHub notifications bot (May 28 2020 at 18:45):

github-actions[bot] commented on Issue #1781:

Subscribe to Label Action

cc @bnjbvr, @fitzgen, @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:wasm", "fuzzing", "lightbeam", "wasmtime:api", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

bnjbvr: cranelift

fitzgen: fuzzing

peterhuene: wasmtime:api, wasmtime:c-api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (May 28 2020 at 21:58):

fitzgen commented on Issue #1781:

Alright, I was missing some C API changes, but I've added them, and CI is green now.

Wasmtime GitHub notifications bot (Jun 01 2020 at 21:56):

fitzgen commented on Issue #1781:

Alright, I believe I've addressed all of your review feedback and discussed the cases where I haven't (host info).

Want to take another look @alexcrichton?

Wasmtime GitHub notifications bot (Jun 01 2020 at 22:24):

github-actions[bot] commented on Issue #1781:

Subscribe to Label Action

cc @fitzgen

<details>
This issue or pull request has been labeled: "cranelift:area:peepmatic"

Thus the following users have been cc'd because of the following labels:

fitzgen: cranelift:area:peepmatic

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Jun 02 2020 at 16:47):

fitzgen commented on Issue #1781:

One thing I wanted to point out, though. We talked a bit about how host info is useful becuase it has the same lifetime of the ExternRef, but I'm not actually seeing where that happens? If you set_host_info for something, I don't see a destructor of ExternRef which the calls the finalizer when the ExternRef goes away. (I think this just happens when the Store goes away?)

Yeah, this is why it is useful at the API level. Our implementation doesn't do that yet :sweat_smile:

Last updated: Nov 22 2024 at 16:03 UTC