Stream: git-wasmtime

Topic: wasmtime / Issue #1744 x86: add encoding for bnot.b1

Wasmtime GitHub notifications bot (May 21 2020 at 22:33):

github-actions[bot] commented on Issue #1744:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift", "cranelift:meta"

Thus the following users have been cc'd because of the following labels:

• bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (May 22 2020 at 00:10):

iximeow commented on Issue #1744:

I'd rather not be the one to :heavy_check_mark: just because the encoding change is exactly what I'd suggested, so approving feels like subverting the review process.

@abrown if you were looking at B1 rules recently, want to give this a look?

Wasmtime GitHub notifications bot (May 22 2020 at 05:08):

whitequark commented on Issue #1744:

(She, not he)

Wasmtime GitHub notifications bot (May 27 2020 at 16:42):

bjorn3 commented on Issue #1744:

@abrown Your review doesn't contain any code comments.

Wasmtime GitHub notifications bot (May 28 2020 at 01:23):

whitequark commented on Issue #1744:

What does this mean?

FAIL filetests\filetests\isa\x86\bnot-b1.clif: run(u0:323):
InvalidTargetIsa

Wasmtime GitHub notifications bot (May 29 2020 at 10:55):

whitequark commented on Issue #1744:

Thanks!

Last updated: Nov 22 2024 at 17:03 UTC