Stream: git-wasmtime

Topic: wasmtime / Issue #1742 [WIP] Add support for Windows x32 ABI

view this post on Zulip Wasmtime GitHub notifications bot (May 21 2020 at 20:21):

github-actions[bot] commented on Issue #1742:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 04:09):

abrown commented on Issue #1742:

@whitequark, why did you have to --enable-simd?

view this post on Zulip Wasmtime GitHub notifications bot (May 22 2020 at 05:10):

whitequark commented on Issue #1742:

@whitequark, why did you have to --enable-simd?

This is a limitation of the x86_32 backend. At the moment, shifts of 64-bit values are legalized to PSLLQ/PSRLQ (#1612) but there's no other applicable legalization rule at all. I wasn't sure what's a good way to legalize 64-bit shifts on 32-bit platforms so I went with the SIMD route that was similar to existing code. Suggestions for a better approach very much welcome!

view this post on Zulip Wasmtime GitHub notifications bot (May 28 2020 at 22:17):

sunfishcode commented on Issue #1742:

the options being "rename SystemV to Ccc", "rename SystemV to Cdecl", "add Cdecl as an alias of SystemV for Windows alone", and "do nothing and just use SystemV on Windows x32"

"do nothing and just use SystemV on Windows x32" and "rename SystemV to Cdecl" sound like they might confuse people; at least, it would probably confuse me if I hadn't just read the rest of the post above :-).

I have a mild preference for "add Cdecl as an alias of SystemV for Windows alone", but I also wouldn't be opposed to "rename SystemV to Ccc" (and introduce a new variant for x86-64).

view this post on Zulip Wasmtime GitHub notifications bot (May 29 2020 at 16:08):

whitequark commented on Issue #1742:

@whitequark, why did you have to --enable-simd?

#1787 fixes that.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 21 2020 at 06:00):

whitequark commented on Issue #1742:

Triage: I believe that with the removal of x86_32 backend this PR is no longer relevant.

Last updated: Nov 22 2024 at 17:03 UTC