Stream: git-wasmtime

Topic: wasmtime / Issue #1739 winx: do not link directly to ntdl...

Wasmtime GitHub notifications bot (May 21 2020 at 17:41):

github-actions[bot] commented on Issue #1739:

Subscribe to Label Action

cc @kubkon

<details>
This issue or pull request has been labeled: "wasi"

Thus the following users have been cc'd because of the following labels:

• kubkon: wasi

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (May 21 2020 at 17:45):

alexcrichton commented on Issue #1739:

Thanks! Could this be done with an AtomicUsize, though, to avoid pulling in an extra dependency?

Wasmtime GitHub notifications bot (May 21 2020 at 17:48):

whitequark commented on Issue #1739:

That'll be kinda ugly, but I can do it, sure. Maybe define our own macro for ntdll imports.

Wasmtime GitHub notifications bot (May 21 2020 at 18:11):

whitequark commented on Issue #1739:

@alexcrichton Done

Wasmtime GitHub notifications bot (May 21 2020 at 18:19):

whitequark commented on Issue #1739:

I have no idea why the macOS test fails.

Wasmtime GitHub notifications bot (May 21 2020 at 18:26):

kubkon commented on Issue #1739:

I have no idea why the macOS test fails.

Hmm, that's very weird indeed. I'll check out your branch locally on my mac and see if it trips for me locally as well.

Wasmtime GitHub notifications bot (May 21 2020 at 18:32):

kubkon commented on Issue #1739:

I have no idea why the macOS test fails.

Hmm, that's very weird indeed. I'll check out your branch locally on my mac and see if it trips for me locally as well.

@whitequark Ok, the CI issue seems to be random Github CI issue so hopefully next time you push, it should work itself out fine.

Last updated: Nov 22 2024 at 17:03 UTC