Wasmtime GitHub notifications bot (May 20 2020 at 22:42): Wasmtime GitHub notifications bot (May 20 2020 at 22:42):peterhuene commented on Issue #1734:
See this comment for a "before and after" codegen.
Wasmtime GitHub notifications bot (May 20 2020 at 22:52):github-actions[bot] commented on Issue #1734:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (May 21 2020 at 22:35):alexcrichton commented on Issue #1734:
I think that this may be all that's necessary to remove this ignore block as well perhaps?
Wasmtime GitHub notifications bot (May 21 2020 at 22:52):peterhuene commented on Issue #1734:
Good catch! I forgot we had disabled tests because of this issue. I'll re-enable.
Wasmtime GitHub notifications bot (May 22 2020 at 00:22):peterhuene commented on Issue #1734:
@bnjbvr would you mind reviewing or suggesting a reviewer from cranelift core? Thanks!
Wasmtime GitHub notifications bot (May 22 2020 at 19:06):peterhuene commented on Issue #1734:
After discussing with Dan, I'm proceeding with merging this with @iximeow's sign-off.
Wasmtime GitHub notifications bot (May 26 2020 at 08:26):bnjbvr commented on Issue #1734:
Oops, sorry I didn't see this among the github-bot mentions; I entirely trust @iximeow's reviews when it comes to Cranelift, for what it's worth :)
Last updated: Nov 22 2024 at 17:03 UTC