Stream: git-wasmtime

Topic: wasmtime / Issue #1705 Implement custom [de]serialization...

Wasmtime GitHub notifications bot (May 14 2020 at 17:08):

fitzgen opened Issue #1705:

Right now we use derive(Serialize, Deserialize) but this results in some unnecessary data being [de]serialized: the map member.

Instead, if we implement [de]serialization by hand, we can serialize the interned integers in order of their id and then recreate the map member on the fly during deserialization. This is what we do for the PathInterner, for example.

This would result in smaller serialized automata generated by peepmatic.

Wasmtime GitHub notifications bot (May 14 2020 at 17:08):

fitzgen labeled Issue #1705:

Right now we use derive(Serialize, Deserialize) but this results in some unnecessary data being [de]serialized: the map member.

Instead, if we implement [de]serialization by hand, we can serialize the interned integers in order of their id and then recreate the map member on the fly during deserialization. This is what we do for the PathInterner, for example.

This would result in smaller serialized automata generated by peepmatic.

Wasmtime GitHub notifications bot (Jun 30 2020 at 06:37):

declanvk commented on Issue #1705:

@fitzgen

Hello, I was interested in peepmatic and I saw this category of issues, so I thought I would attempt some of the easier ones.

I have a PR for this issue (#1944). If more PRs in this area would be welcome/un-welcome, please let me know.

Wasmtime GitHub notifications bot (Jun 30 2020 at 16:58):

fitzgen closed Issue #1705:

Right now we use derive(Serialize, Deserialize) but this results in some unnecessary data being [de]serialized: the map member.

Instead, if we implement [de]serialization by hand, we can serialize the interned integers in order of their id and then recreate the map member on the fly during deserialization. This is what we do for the PathInterner, for example.

This would result in smaller serialized automata generated by peepmatic.

Wasmtime GitHub notifications bot (Jun 30 2020 at 16:59):

fitzgen commented on Issue #1705:

Hi @declanvk! Glad to hear of your interest. Yes, more PRs are very welcome, thanks :)

Last updated: Oct 23 2024 at 20:03 UTC