Wasmtime GitHub notifications bot (Apr 30 2020 at 16:40): Wasmtime GitHub notifications bot (Apr 30 2020 at 16:40):github-actions[bot] commented on Issue #1636:
Subscribe to Label Action
cc @kubkon
<details>
This issue or pull request has been labeled: "wasi"Thus the following users have been cc'd because of the following labels:
- kubkon: wasi
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 30 2020 at 16:42):kubkon commented on Issue #1636:
Hmm, I think this might be a potential duplicate of #1600.
Wasmtime GitHub notifications bot (Apr 30 2020 at 16:52):CryZe commented on Issue #1636:
Oh, you are right, that is indeed seemingly solving the same problem. Feel free to close this one then if the (apparently much more complex) approach there is the better long term one.
Wasmtime GitHub notifications bot (Apr 30 2020 at 17:06):kubkon commented on Issue #1636:
Oh, you are right, that is indeed seemingly solving the same problem. Feel free to close this one then if the (apparently much more complex) approach there is the better long term one.
I think we should hold off with the decision until there's a decision about #1561. If that one lands, then given all the design changes introduced to
wasi-common, it'll make sense to close this one in favour of #1600. However, if we decide not go with #1561, then I'll be happy to land your fix instead. Oh, and thanks a lot for the PR! It's much appreciated! :-)
Wasmtime GitHub notifications bot (May 21 2020 at 22:03):whitequark commented on Issue #1636:
Looks like #1561 did land.
Wasmtime GitHub notifications bot (Jun 09 2020 at 18:22):kubkon commented on Issue #1636:
Thanks for the PR @CryZe. Since we’ve decided to go with #1600, this PR has now been superseded so I’ll go ahead and close it.
Last updated: Nov 22 2024 at 17:03 UTC