Stream: git-wasmtime

Topic: wasmtime / Issue #1620 Implement basic support for the Li...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 14:54):

alexcrichton commented on Issue #1620:

r=me on the wasmtime bits here, thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Apr 28 2020 at 18:53):

github-actions[bot] commented on Issue #1620:

Subscribe to Label Action

cc @bnjbvr, @peterhuene

<details>
This issue or pull request has been labeled: "cranelift", "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2020 at 23:07):

stuaxo commented on Issue #1620:

This is awesome, could it help Rust compile dos executables ?

https://github.com/Serentty/rusty-dos/

view this post on Zulip Wasmtime GitHub notifications bot (May 03 2020 at 23:11):

whitequark commented on Issue #1620:

This is awesome, could it help Rust compile dos executables ?

Certainly not, this PR is not even remotely related to DOS and I cannot imagine that Cranelift would ever be able to emit real-mode x86 machine code.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2020 at 11:45):

bjorn3 commented on Issue #1620:

Cranelift could theoretically add data32 prefixes everywhere.

view this post on Zulip Wasmtime GitHub notifications bot (May 04 2020 at 12:10):

stuaxo commented on Issue #1620:

Oh heh, I meant 32 bit protected mode DOS, but fair enough.

view this post on Zulip Wasmtime GitHub notifications bot (May 06 2020 at 02:21):

whitequark commented on Issue #1620:

I'd give ArgumentPurpose::CalleeSaved a shot here, this is well after register allocation so it's probably free of risk in side effects there.

I tried that first and I think it either didn't work correctly or generated useless instructions. I can recheck it if you want to be sure, but that was my first implementation.

view this post on Zulip Wasmtime GitHub notifications bot (May 06 2020 at 02:35):

iximeow commented on Issue #1620:

I'd greatly appreciate if you could check again. If it fails in a weird way I'd think Cranelift should be better-behaved. Worst case, it helps motivate an atypical ArgumentPurpose that isn't CalleeSave. Or, we should be clearer about the semantics of ArgumentPurpose and Normal should be acceptable (by being an argument to the function, even if it's not an ABI-mandated one)

view this post on Zulip Wasmtime GitHub notifications bot (May 08 2020 at 05:42):

whitequark commented on Issue #1620:

@iximeow I stand corrected--there seems to be no observable difference and everything apperas to work just fine with %rsp as CSR.

view this post on Zulip Wasmtime GitHub notifications bot (May 08 2020 at 05:42):

whitequark edited a comment on Issue #1620:

@iximeow I stand corrected--there seems to be no observable difference in the generated code and everything appears to work just fine with %rsp as CSR.

view this post on Zulip Wasmtime GitHub notifications bot (May 09 2020 at 09:44):

whitequark commented on Issue #1620:

I've updated the PR to use ArgumentPurpoe::CalleeSave.

Last updated: Oct 23 2024 at 20:03 UTC