Wasmtime GitHub notifications bot (Apr 24 2020 at 09:08): Wasmtime GitHub notifications bot (Apr 24 2020 at 09:08):bnjbvr opened Issue #1588:
... because then it means that you can get a new compilation failure unrelated to a PR, just because you compiled on a day where a new warning had been introduced in Rust-nightly.
For instance: https://github.com/bytecodealliance/wasmtime/pull/1578/checks?check_run_id=614733207 which I can't locally reproduce, even after upgrading to latest Rustc nightly (i suspect this is because i'm using RLS and all, and so it skipped updating as there was a missing rustup component).
cc @alexcrichton
Wasmtime GitHub notifications bot (Apr 24 2020 at 09:08):bnjbvr labeled Issue #1588:
... because then it means that you can get a new compilation failure unrelated to a PR, just because you compiled on a day where a new warning had been introduced in Rust-nightly.
For instance: https://github.com/bytecodealliance/wasmtime/pull/1578/checks?check_run_id=614733207 which I can't locally reproduce, even after upgrading to latest Rustc nightly (i suspect this is because i'm using RLS and all, and so it skipped updating as there was a missing rustup component).
cc @alexcrichton
Wasmtime GitHub notifications bot (Apr 24 2020 at 10:15):tschneidereit commented on Issue #1588:
I think this makes sense, yes. We should probably still keep warn-as-error for beta and release builds, meaning we would still get breakage unrelated to changes, but much more rarely.
If we don't have warn-as-error anywhere, I fear we'll quickly see a lot of warnings creep up, making it harder to discern things that should really be addressed from those we don't care about.
Wasmtime GitHub notifications bot (Apr 24 2020 at 15:13):alexcrichton commented on Issue #1588:
Wasmtime GitHub notifications bot (Apr 24 2020 at 15:55):alexcrichton closed Issue #1588:
... because then it means that you can get a new compilation failure unrelated to a PR, just because you compiled on a day where a new warning had been introduced in Rust-nightly.
For instance: https://github.com/bytecodealliance/wasmtime/pull/1578/checks?check_run_id=614733207 which I can't locally reproduce, even after upgrading to latest Rustc nightly (i suspect this is because i'm using RLS and all, and so it skipped updating as there was a missing rustup component).
cc @alexcrichton
Last updated: Dec 23 2024 at 12:05 UTC