Wasmtime GitHub notifications bot (Apr 22 2020 at 01:53): Wasmtime GitHub notifications bot (Apr 22 2020 at 01:53):github-actions[bot] commented on Issue #1575:
Subscribe to Label Action
cc @bnjbvr
<details>
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:module"Thus the following users have been cc'd because of the following labels:
- bnjbvr: cranelift
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Apr 22 2020 at 13:35):bnjbvr commented on Issue #1575:
(To be clear, I only commented the third commit which is passing SourceLoc information)
Wasmtime GitHub notifications bot (Apr 23 2020 at 00:10):cfallin commented on Issue #1575:
Thanks! Updated, PTAL.
@bjorn3:
It would be nice if it also said where the prologue ends and where the epilogue starts.
Sure, that'd be useful metadata as well; but it seems there's no downstream consumer of that at the moment? I suppose it might be better to wait until we have a need for it (or build out more detailed debuginfo infra)...
Wasmtime GitHub notifications bot (Apr 23 2020 at 09:29):bjorn3 commented on Issue #1575:
That would be https://github.com/bjorn3/rustc_codegen_cranelift/issues/937, though in case of the prologue I will likely want to include argument stores generated by cg_clif.
Wasmtime GitHub notifications bot (Apr 23 2020 at 20:07):cfallin commented on Issue #1575:
@bjorn3 OK, that seems like a reasonable addition. If you don't mind, I think we should postpone that for a followup PR, so that we can land this and get to full test correctness first.
Last updated: Dec 23 2024 at 12:05 UTC