Stream: git-wasmtime

Topic: wasmtime / Issue #1561 Introduce strongly-typed system pr...

Wasmtime GitHub notifications bot (Apr 22 2020 at 09:54):

kubkon commented on Issue #1561:

OK, so I've gone ahead and done a little bit of refactoring that IMHO should aid readability. Namely, I've delegated defining OsDir struct to OS-specific modules (BSD, Linux, Emscripten, Windows). This way, OsDir can safely re-use OsHandle for raw OS handle storage, and can store some aux data such as an initialized stream ptr in case of BSD. As a result, we can safely
get rid of OsDirHandle which IMHO was causing unnecessary noise and overcomplicating the design. On the other hand, delegating definition of OsDir to OS-specific modules isn't super clean in and of itself either. Perhaps there's a better way of handling this?

Wasmtime GitHub notifications bot (Apr 27 2020 at 15:37):

alexcrichton commented on Issue #1561:

Sorry for the delay, but I think I won't have a ton of time to review this. It sounds reasonable enough but I don't have time to dig into the details right now.

Wasmtime GitHub notifications bot (May 05 2020 at 17:05):

kubkon commented on Issue #1561:

@sunfishcode do you think we're go green for merging or would you like to take another look at the PR?

Last updated: Nov 22 2024 at 17:03 UTC