Stream: git-wasmtime

Topic: wasmtime / Issue #1559 SystemV struct arguments

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 16:42):

fitzgen commented on Issue #1559:

Are the TODOs in the original comment taken care of?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 17:16):

bjorn3 commented on Issue #1559:

Are the TODOs in the original comment taken care of?

Thanks for reminding me.

Don't misuse INVALID, but introduce a proper type.

I have introduced the SARG__ type.

Implement this correctly for WindowsFastcall or give an error.

I will add an error for now.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 17:23):

bjorn3 commented on Issue #1559:

I have turned it into a panic, as there is no way to report an error in the function signature legalization.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 17:24):

bjorn3 commented on Issue #1559:

Should I squash?

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 17:28):

fitzgen commented on Issue #1559:

That would be helpful, yes.

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 17:30):

bjorn3 commented on Issue #1559:

Splat

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 19:50):

bjorn3 commented on Issue #1559:

CI passed

view this post on Zulip Wasmtime GitHub notifications bot (Jun 29 2020 at 21:22):

fitzgen commented on Issue #1559:

Thanks for rebasing @bjorn3.

I took a look at the code, but I don't feel familiar enough with many of the bits that it is touching to be the official reviewer, determine if this is the proper approach to solving the problem, etc. I think @bnjbvr or @sunfishcode would be better reviewers.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 16:43):

cfallin commented on Issue #1559:

Also, to be clear, like others above I'd also be more comfortable if someone who's worked more on the old backend could review as well.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2020 at 19:21):

cfallin commented on Issue #1559:

@bnjbvr , would you mind sanity-checking this? LGTM from code-quality perspective, just want to make sure I'm not missing anything w.r.t. interactions with the old ABI mechanisms.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 16 2020 at 18:20):

bjorn3 commented on Issue #1559:

macOS doesn't have any logs for the failure.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 17 2020 at 10:00):

bjorn3 commented on Issue #1559:

It passed this time.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 17 2020 at 10:09):

bjorn3 commented on Issue #1559:

Thanks!

Last updated: Dec 23 2024 at 13:07 UTC