Stream: git-wasmtime

Topic: wasmtime / Issue #1534 [bugpoint] Remove block params

Wasmtime GitHub notifications bot (Apr 17 2020 at 17:04):

github-actions[bot] commented on Issue #1534:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

• bnjbvr: cranelift

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Apr 17 2020 at 17:23):

bjorn3 commented on Issue #1534:

CI ran out of disk space?

Wasmtime GitHub notifications bot (Apr 17 2020 at 17:45):

teapotd commented on Issue #1534:

@bjorn3

I just noticed that Mutator::did_crash is never called. Maybe you can remove it in this PR? Otherwise I will open a PR myself.

It is called in reduce and it's used by MergeBlocks mutator:

https://github.com/bytecodealliance/wasmtime/blob/7d88384c0fe087cd80a3d8ae1bbc80950b2b7d91/cranelift/src/bugpoint.rs#L764-L765

https://github.com/bytecodealliance/wasmtime/blob/7d88384c0fe087cd80a3d8ae1bbc80950b2b7d91/cranelift/src/bugpoint.rs#L650-L652

Wasmtime GitHub notifications bot (Apr 17 2020 at 17:51):

bjorn3 commented on Issue #1534:

It is called in reduce and it's used by MergeBlocks mutator:

Somehow the call didn't show up when I did Ctrl-F.

Last updated: Dec 23 2024 at 12:05 UTC