Stream: git-wasmtime

Topic: wasmtime / Issue #1517 Add ability to call CLIF functions...

view this post on Zulip Wasmtime GitHub notifications bot (Apr 15 2020 at 21:07):

abrown commented on Issue #1517:

I expect this to fail because there are no encodings for booleans in load and store.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 15 2020 at 21:08):

abrown edited a comment on Issue #1517:

I expect this to fail because there are no encodings for booleans in load and store. @sunfishcode and others: should we add these encodings or should make_trampoline do something special for booleans?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 15 2020 at 21:25):

github-actions[bot] commented on Issue #1517:

Subscribe to Label Action

cc @bnjbvr

<details>
This issue or pull request has been labeled: "cranelift"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Apr 16 2020 at 16:45):

abrown commented on Issue #1517:

@alexcrichton, here's the PR with the trampolines I was referring to.

view this post on Zulip Wasmtime GitHub notifications bot (Apr 16 2020 at 16:45):

abrown edited a comment on Issue #1517:

@alexcrichton, here's the PR with the trampolines I was referring to. (You might notice they look pretty similar to the ones you created :wink:).

view this post on Zulip Wasmtime GitHub notifications bot (Apr 16 2020 at 20:41):

alexcrichton commented on Issue #1517:

Nice! FWIW reading this over I think there's actually not a whole lot that we'd share between wasmtime and cranelift. Only a few small loops/etc would be shared, and otherwise it seems like we'd probably bend over backwards too much trying to cater to both use cases. In that sense I'd personally be ok if we just left this duplication in the two?

view this post on Zulip Wasmtime GitHub notifications bot (Apr 18 2020 at 22:20):

abrown commented on Issue #1517:

Ok, I think this is ready: since the x86 backend does not have encodings for loading and storing booleans, I took @sunfishcode's suggestion and convert boolean values from (load + icmp_imm ne ..., 0) and to (bint + store).

Last updated: Dec 23 2024 at 12:05 UTC