Wasmtime GitHub notifications bot (Apr 09 2020 at 22:01): Wasmtime GitHub notifications bot (Apr 09 2020 at 22:01):github-actions[bot] commented on Issue #1494:
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:meta"
<details> <summary>Users Subscribed to "cranelift"</summary>
- @bnjbvr
</details>
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Wasmtime GitHub notifications bot (Apr 12 2020 at 03:24):cfallin commented on Issue #1494:
Thanks @sunfishcode and @bjorn3 for the comments -- I think I've addressed everything, except for the open questions in the unresolved comments above.
Wasmtime GitHub notifications bot (Apr 14 2020 at 00:58):cfallin commented on Issue #1494:
Thanks @sunfishcode and @bjorn3 for the further review comments! I think I've addressed everything except for the open questions in unresolved threads above. Happy to take further review comments, of course.
Wasmtime GitHub notifications bot (Apr 15 2020 at 23:33):cfallin commented on Issue #1494:
Alright, I think I've addressed all comments, finally. Let's wait to see if the latest CI run succeeds; then, @sunfishcode, if you're OK with it, I can hit the Merge button (or feel free to do so yourself if that's the custom here). Thanks for all the review work!
Wasmtime GitHub notifications bot (Apr 16 2020 at 16:56):cfallin commented on Issue #1494:
@sunfishcode actually, I don't have permissions to merge, so please feel do hit the big green button when you're happy!
Wasmtime GitHub notifications bot (Apr 16 2020 at 16:57):cfallin commented on Issue #1494:
(Actually, I take that back, Till just added me. Let me know if you're happy with the final version and I'll merge.)
Wasmtime GitHub notifications bot (Apr 16 2020 at 17:01):cfallin commented on Issue #1494:
As per IM with @sunfishcode, merging now!
Last updated: Oct 23 2024 at 20:03 UTC