wasmtime / Issue #1473 clif-util: don't require a target ... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / Issue #1473 clif-util: don't require a target ...

Wasmtime GitHub notifications bot (Apr 06 2020 at 16:55):

Translating wasm into clif should not require a target, but right now it does:
$ cargo run -- wasm -tp ~/scratch/two-plus-five.wasm
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `/home/fitzgen/wasmtime/target/debug/clif-util wasm -tp /home/fitzgen/scratch/two-plus-five.wasm`
Error: the wasm command requires an explicit isa.
When the -t flag is passed, and therefore we are only doing wasm to clif translation, we should not require a --target flag.

Wasmtime GitHub notifications bot (Apr 06 2020 at 16:55):

fitzgen labeled Issue #1473:

Translating wasm into clif should not require a target, but right now it does:
$ cargo run -- wasm -tp ~/scratch/two-plus-five.wasm
    Finished dev [unoptimized + debuginfo] target(s) in 0.06s
     Running `/home/fitzgen/wasmtime/target/debug/clif-util wasm -tp /home/fitzgen/scratch/two-plus-five.wasm`
Error: the wasm command requires an explicit isa.
When the -t flag is passed, and therefore we are only doing wasm to clif translation, we should not require a --target flag.

Wasmtime GitHub notifications bot (Apr 06 2020 at 16:55):

github-actions[bot] commented on Issue #1473:

Subscribe to Label Action

This issue or pull request has been labeled: "cranelift"

<details> <summary>Users Subscribed to "cranelift"</summary>

@bnjbvr

</details>

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

Wasmtime GitHub notifications bot (Feb 03 2021 at 20:44):

bjorn3 commented on Issue #1473:

The target is necessary to get the pointer size for things like reference types.

Wasmtime GitHub notifications bot (Feb 03 2021 at 21:57):

abrown commented on Issue #1473:

I think it would be nice to have a sane default here: if --target is not passed, try to use the host's native target. I've run into this several times in the past and it's annoying.

Last updated: Oct 23 2024 at 20:03 UTC