Stream: git-wasmtime

Topic: wasmtime / Issue #1458 Cranelift: Build failure during te...

Wasmtime GitHub notifications bot (Apr 02 2020 at 03:38):

jlb6740 labeled Issue #1458:

Thanks for opening a bug report! Please answer the questions below
if they're relevant and delete this text before submitting.

• What are the steps to reproduce the issue? Can you include a CLIF test case,
  ideally reduced with the bugpoint clif-util command?

• What do you expect to happen? What does actually happen? Does it panic, and
  if so, with which assertion?

• Which Cranelift version / commit hash / branch are you using?

• If relevant, can you include some extra information about your environment?
  (Rust version, operating system, architecture...)

Hi .. I am seeing test failures in the pr here: https://github.com/bytecodealliance/wasmtime/pull/819 but the failure is unrelated to the patch. Specifically it is failing to a warning about an unnecessary brace around an assignment in some code in cranelift:


When I run this on my target machine I see no such error so I can't reproduce. Furthermore it is unclear why the error for each line number is being printed out twice. Perhaps this is some testing configuration issue.

Wasmtime GitHub notifications bot (Apr 02 2020 at 03:38):

jlb6740 opened Issue #1458:

Thanks for opening a bug report! Please answer the questions below
if they're relevant and delete this text before submitting.

• What are the steps to reproduce the issue? Can you include a CLIF test case,
  ideally reduced with the bugpoint clif-util command?

• What do you expect to happen? What does actually happen? Does it panic, and
  if so, with which assertion?

• Which Cranelift version / commit hash / branch are you using?

• If relevant, can you include some extra information about your environment?
  (Rust version, operating system, architecture...)

Hi .. I am seeing test failures in the pr here: https://github.com/bytecodealliance/wasmtime/pull/819 but the failure is unrelated to the patch. Specifically it is failing to a warning about an unnecessary brace around an assignment in some code in cranelift:


When I run this on my target machine I see no such error so I can't reproduce. Furthermore it is unclear why the error for each line number is being printed out twice. Perhaps this is some testing configuration issue.

Wasmtime GitHub notifications bot (Apr 02 2020 at 03:38):

jlb6740 labeled Issue #1458:

Thanks for opening a bug report! Please answer the questions below
if they're relevant and delete this text before submitting.

• What are the steps to reproduce the issue? Can you include a CLIF test case,
  ideally reduced with the bugpoint clif-util command?

• What do you expect to happen? What does actually happen? Does it panic, and
  if so, with which assertion?

• Which Cranelift version / commit hash / branch are you using?

• If relevant, can you include some extra information about your environment?
  (Rust version, operating system, architecture...)

Hi .. I am seeing test failures in the pr here: https://github.com/bytecodealliance/wasmtime/pull/819 but the failure is unrelated to the patch. Specifically it is failing to a warning about an unnecessary brace around an assignment in some code in cranelift:


When I run this on my target machine I see no such error so I can't reproduce. Furthermore it is unclear why the error for each line number is being printed out twice. Perhaps this is some testing configuration issue.

Wasmtime GitHub notifications bot (Apr 02 2020 at 03:38):

github-actions[bot] commented on Issue #1458:

Subscribe to Label Action

This issue or pull request has been labeled: "cranelift"

<details> <summary>Users Subscribed to "cranelift"</summary>

• @bnjbvr

</details>

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

Wasmtime GitHub notifications bot (Apr 02 2020 at 06:07):

jlb6740 commented on Issue #1458:

>

Oh ... or perhaps there is a regression in nightly?

Wasmtime GitHub notifications bot (Apr 02 2020 at 09:46):

bjorn3 commented on Issue #1458:

Nightly introduced a new lint. On CI -Dwarnings is passed, so the lint is set to deny instead of warn. Using -Dwarnings is excempt from the stability guarantees as otherwise it would be impossible to introduce new lints.

Wasmtime GitHub notifications bot (Apr 02 2020 at 13:58):

bnjbvr closed Issue #1458:

Thanks for opening a bug report! Please answer the questions below
if they're relevant and delete this text before submitting.

• What are the steps to reproduce the issue? Can you include a CLIF test case,
  ideally reduced with the bugpoint clif-util command?

• What do you expect to happen? What does actually happen? Does it panic, and
  if so, with which assertion?

• Which Cranelift version / commit hash / branch are you using?

• If relevant, can you include some extra information about your environment?
  (Rust version, operating system, architecture...)

Hi .. I am seeing test failures in the pr here: https://github.com/bytecodealliance/wasmtime/pull/819 but the failure is unrelated to the patch. Specifically it is failing to a warning about an unnecessary brace around an assignment in some code in cranelift:


When I run this on my target machine I see no such error so I can't reproduce. Furthermore it is unclear why the error for each line number is being printed out twice. Perhaps this is some testing configuration issue.

Wasmtime GitHub notifications bot (Apr 02 2020 at 13:58):

bnjbvr commented on Issue #1458:

Fixed by #1459, thanks for the patch!

Last updated: Nov 22 2024 at 17:03 UTC