Stream: git-wasmtime

Topic: wasmtime / Issue #1445 wiggle: fix cycle between wiggle a...


view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 18:04):

github-actions[bot] commented on Issue #1445:

Subscribe to Label Action

This issue or pull request has been labeled: "wasi"

<details> <summary>Users Subscribed to "wasi"</summary>

</details>

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 18:34):

alexcrichton commented on Issue #1445:

I personally think it's nice to have tests in the "main crate", but I'm fine with whatever works. I do think that this can be fixed by removing the version = "..." requirement as well since those dependencies just won't be published to crates.io

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 18:36):

pchickey commented on Issue #1445:

I didn't realize that was an option for fixing this. I'm happy to close this and fix it the other way.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 31 2020 at 18:37):

pchickey edited a comment on Issue #1445:

I didn't realize that was an option for fixing this. I'm happy to close this and fix it the other way. Nobody should depend on or use wiggle-test outside of the wasmtime tree, so I like your approach better.


Last updated: Dec 23 2024 at 12:05 UTC