Stream: git-wasmtime

Topic: wasmtime / Issue #1430 Generate trace logs in wiggle albe...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 28 2020 at 17:35):

github-actions[bot] commented on Issue #1430:

Subscribe to Label Action

This issue or pull request has been labeled: "wasi"

<details> <summary>Users Subscribed to "wasi"</summary>

</details>

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 30 2020 at 17:58):

kubkon commented on Issue #1430:

Looks great! :)

It may be a good idea to use \t for trace padding. For instance:

trace!("\t| path='{}'", host_path);

instead of

trace!(" | path='{}'", host_path);

This could make it easier to write coherent tracing across the codebase. On the other hand, such refactor may be out of scope of this PR.

Hmm, yeah, let's leave it for a subsequent refactor.

Last updated: Nov 22 2024 at 16:03 UTC