Wasmtime GitHub notifications bot (Mar 24 2020 at 21:39): Wasmtime GitHub notifications bot (Mar 24 2020 at 21:39):alexcrichton commented on Issue #1397:
I don't think we actually use this script on CI, so should we remove the script? If not should we switch CI to running this script?
Wasmtime GitHub notifications bot (Mar 24 2020 at 21:48):sunfishcode commented on Issue #1397:
It's not great to run a test-all.sh script in CI, because it means the CI has to treat it like one big command with a big log output that you have to wade through.
Is there a recommend way to do the opposite -- run the CI scripts locally?
Wasmtime GitHub notifications bot (Mar 25 2020 at 14:12):alexcrichton commented on Issue #1397:
It's true yeah that it's not a great setup for CI, but if we don't actually run scripts like this on CI they inevitably break and fall out of date. In that sense if we want to keep it up to date I think we should run it on CI, otherwise I think we'll probably want to remove it since "test all" is "run ci" rather than running this script.
Last updated: Dec 23 2024 at 13:07 UTC