github-actions[bot] commented on Issue #1334:
Subscribe to Label Action
This issue or pull request has been labeled: "wasmtime:api"
<details> <summary>Users Subscribed to "wasmtime:api"</summary>
- @peterhuene
</details>
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
alexcrichton commented on Issue #1334:
Thanks for this!
I might actually differ a bit in a preference of how we go about doing this. I would advocate for a dedicated
Config
method being added for this which is then called explicitly when fuzzing. That way fuzzing is self-documented in theConfig
creation of the fuzzer and then this is also available to all other users too.
teapotd commented on Issue #1334:
Actually, shouldn't it belong to the
fuzzing
crate? It already creates config with some additional options by default:I think it would be best to make it
pub
orpub(crate)
, use it as base for custom configurations in entirefuzzing
create and enable NaN canonicalization flag here.
teapotd edited a comment on Issue #1334:
Actually, shouldn't it belong to the
fuzzing
crate? It already creates config with some additional options by default:I think it would be best to make it
pub
orpub(crate)
, use it as base for custom configurations in entirefuzzing
create and enable NaN canonicalization flag there.
alexcrichton commented on Issue #1334:
Yeah that's my thinking, we'd have a method on
Config
which is called by thefuzzing
crate.
teapotd commented on Issue #1334:
No, I meant to have a function that creates appropriate
Config
in thefuzzing
crate.fuzz_default_config
is already in thefuzzing
crate.
teapotd edited a comment on Issue #1334:
No, I meant to have a function that creates appropriate
Config
in thefuzzing
crate.Config
is defined inapi
.fuzz_default_config
is already in thefuzzing
crate.
alexcrichton commented on Issue #1334:
@teapotd yes but the
fuzzing
crate depends on thewasmtime
crate, and needs to call a public method onConfig
to enable nan canonicalization. The method needs to be defined in thewasmtime
crate and then thefuzzing
crate would call that.
teapotd commented on Issue #1334:
@alexcrichton Ah, that's what you meant. Thanks!
github-actions[bot] commented on Issue #1334:
Subscribe to Label Action
This issue or pull request has been labeled: "fuzzing"
<details> <summary>Users Subscribed to "fuzzing"</summary>
- @fitzgen
</details>
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
teapotd commented on Issue #1334:
r? @alexcrichton
alexcrichton commented on Issue #1334:
Nice, thanks!
Last updated: Dec 23 2024 at 12:05 UTC