Stream: git-wasmtime

Topic: wasmtime / Issue #1334 fuzzing: Enable NaN canonicalization

Wasmtime GitHub notifications bot (Mar 17 2020 at 10:58):

github-actions[bot] commented on Issue #1334:

Subscribe to Label Action

This issue or pull request has been labeled: "wasmtime:api"

<details> <summary>Users Subscribed to "wasmtime:api"</summary>

• @peterhuene

</details>

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

Wasmtime GitHub notifications bot (Mar 17 2020 at 14:01):

alexcrichton commented on Issue #1334:

Thanks for this!

I might actually differ a bit in a preference of how we go about doing this. I would advocate for a dedicated Config method being added for this which is then called explicitly when fuzzing. That way fuzzing is self-documented in the Config creation of the fuzzer and then this is also available to all other users too.

Wasmtime GitHub notifications bot (Mar 21 2020 at 17:26):

teapotd commented on Issue #1334:

Actually, shouldn't it belong to the fuzzing crate? It already creates config with some additional options by default:

https://github.com/bytecodealliance/wasmtime/blob/c202a8eeaf8f72a5e87d50ac2f0d58c9170b3488/crates/fuzzing/src/oracles.rs#L19-L29

I think it would be best to make it pub or pub(crate), use it as base for custom configurations in entire fuzzing create and enable NaN canonicalization flag here.

Wasmtime GitHub notifications bot (Mar 21 2020 at 19:09):

teapotd edited a comment on Issue #1334:

Actually, shouldn't it belong to the fuzzing crate? It already creates config with some additional options by default:

https://github.com/bytecodealliance/wasmtime/blob/c202a8eeaf8f72a5e87d50ac2f0d58c9170b3488/crates/fuzzing/src/oracles.rs#L19-L29

I think it would be best to make it pub or pub(crate), use it as base for custom configurations in entire fuzzing create and enable NaN canonicalization flag there.

Wasmtime GitHub notifications bot (Mar 23 2020 at 13:57):

alexcrichton commented on Issue #1334:

Yeah that's my thinking, we'd have a method on Config which is called by the fuzzing crate.

Wasmtime GitHub notifications bot (Mar 23 2020 at 15:02):

teapotd commented on Issue #1334:

No, I meant to have a function that creates appropriate Config in the fuzzing crate. fuzz_default_config is already in the fuzzing crate.

Wasmtime GitHub notifications bot (Mar 23 2020 at 15:03):

teapotd edited a comment on Issue #1334:

No, I meant to have a function that creates appropriate Config in the fuzzing crate. Config is defined in api. fuzz_default_config is already in the fuzzing crate.

Wasmtime GitHub notifications bot (Mar 23 2020 at 16:24):

alexcrichton commented on Issue #1334:

@teapotd yes but the fuzzing crate depends on the wasmtime crate, and needs to call a public method on Config to enable nan canonicalization. The method needs to be defined in the wasmtime crate and then the fuzzing crate would call that.

Wasmtime GitHub notifications bot (Mar 23 2020 at 16:36):

teapotd commented on Issue #1334:

@alexcrichton Ah, that's what you meant. Thanks!

Wasmtime GitHub notifications bot (Mar 23 2020 at 20:03):

github-actions[bot] commented on Issue #1334:

Subscribe to Label Action

This issue or pull request has been labeled: "fuzzing"

<details> <summary>Users Subscribed to "fuzzing"</summary>

• @fitzgen

</details>

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

Wasmtime GitHub notifications bot (Mar 31 2020 at 13:47):

teapotd commented on Issue #1334:

r? @alexcrichton

Wasmtime GitHub notifications bot (Mar 31 2020 at 14:22):

alexcrichton commented on Issue #1334:

Nice, thanks!

Last updated: Nov 22 2024 at 17:03 UTC