Stream: git-wasmtime

Topic: wasmtime / Issue #1310 Enable jitdump profiling support b...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 17:33):

alexcrichton commented on Issue #1310:

cc @jlb6740

I was playing around with this some more and this, for me at least, also seems to support -g out of the box. I passed -g and got at least some line number/etc in the output. They didn't seem like the most accurate things in the world, but then again I've found perf's sources to rarely be that accurate anyway!

In any case I'm curious on your thoughts on this!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 19:06):

jlb6740 commented on Issue #1310:

The jitdump Cargo feature is now enabled by default which means that
our published binaries, C API artifacts, and crates will support
profiling at runtime by default.

@alexcrichton I think initially this was designed to not be the case out of concern to not bring in dependent crates if profiling support wasn't desired. Specifically for a production build jitdump support should not be baked in by default I don't think. Also, when vtune support is added should that also be default? Should we just make this default for the debug build but optional for the production build?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 19:16):

alexcrichton commented on Issue #1310:

Oh definitely yeah, I think we want the ability to build without profiling support, but on reading all this it looks like the profiling support is pretty lightweight so it seemed reasonable to enable by default. The binaries we ship I think we're ok enabling them, and then users building their own binaries still have the option to turn this feature on/off.

I'm fine going either way myself, I just found this to be so slick once it worked it seemed like we'd want it in official builds by default :)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 20:00):

github-actions[bot] commented on Issue #1310:

Subscribe to Label Action

This issue or pull request has been labeled: "wasi", "wasmtime:api", "wasmtime:c-api", "wasmtime:docs"

<details> <summary>Users Subscribed to "wasmtime:api"</summary>

</details>
<details> <summary>Users Subscribed to "wasmtime:c-api"</summary>

</details>

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

Last updated: Nov 22 2024 at 16:03 UTC