Stream: git-wasmtime

Topic: wasmtime / Issue #1298 Increase the size of the sigaltstack.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2020 at 15:44):

alexcrichton commented on Issue #1298:

Also FWIW I see this as mostly a temporary patch. https://github.com/bytecodealliance/wasmtime/issues/900 is sort of fundamentaly un-fixable with our current strategy of stack overflow detection because we'll always have the case that wasm calls a ton of functions then calls some native code which aborts the whole process instead of returning a wasm trap. For example you could have something like:

(module
  (import "" "" (func $f))
  (func $recurse
    call $f
    call $recurse)
  (start $recurse))

That would test calling a native function on every single wasm stack frame, and eventually the native code will abort the process due to stack overflow when in reality this is a wasm stack overflow condition.

This'll make it so stack overflow doesn't trigger a second stack overflow when generating a backtrace, but we'll still want to handle this recursive case.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2020 at 17:17):

github-actions[bot] commented on Issue #1298:

Subscribe to Label Action

This issue or pull request has been labeled: "w", "a", "s", "m", "t", "i", "e"

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2020 at 21:31):

github-actions[bot] commented on Issue #1298:

Subscribe to Label Action

This issue or pull request has been labeled: "wasmtime", "wasmtime:api"

<details> <summary>Users Subscribed to "wasmtime:api"</summary>

</details>

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 12 2020 at 21:56):

fitzgen deleted a comment on Issue #1298:

Subscribe to Label Action

This issue or pull request has been labeled: "w", "a", "s", "m", "t", "i", "e"

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 21:03):

sunfishcode commented on Issue #1298:

Closing in favor of #1315.

Last updated: Dec 23 2024 at 12:05 UTC