Stream: git-wasmtime

Topic: wasmtime / Issue #1280 [cranelift] CONTRIBUTING.md is a d...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 12:56):

jyn514 opened Issue #1280:

Probably got lost in the switch to wasmtime. https://github.com/bytecodealliance/wasmtime/blob/master/cranelift/README.md#contributing links to https://github.com/bytecodealliance/wasmtime/blob/master/cranelift/CONTRIBUTING.md, but there's no file there. Not sure whether you want this to link to https://github.com/bytecodealliance/wasmtime/blob/master/CONTRIBUTING.md or something in https://github.com/bytecodealliance/wasmtime/tree/master/cranelift/docs, so I didn't make a PR.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 12:58):

jyn514 edited Issue #1280:

Probably got lost in the switch to wasmtime. cranelift/README.md links to cranelift/CONTRIBUTING.md, but there's no file there. Not sure whether you want this to link to CONTRIBUTING.md or something in cranelift/docs, so I didn't make a PR.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 14:10):

abrown commented on Issue #1280:

Linking to the wasmtime-level CONTRIBUTING.md would make sense to me.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 14:15):

jyn514 commented on Issue #1280:

Is there a reason not to add back the old CONTRIBUTING.md file? https://github.com/bytecodealliance/cranelift/blob/3d1cdec0837684b1656bcb6194be6c31302b5d3e/CONTRIBUTING.md

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 14:19):

abrown commented on Issue #1280:

I suspect it was removed to remove duplication; @alexcrichton?

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 14:21):

abrown commented on Issue #1280:

@jyn514, what does the cranelift file have that is missing in the wasmtime file? (I mean what information do you feel is important and missing?)

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 14:27):

jyn514 commented on Issue #1280:

Actually, looking back at both it seems like they cover most of the same info, so I'd be ok with only keeping the wasmtime website. I was a little put off by most of the sections on the website being missing, but 10. Contributing all seems to be there.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 11 2020 at 14:35):

alexcrichton commented on Issue #1280:

Oh oops sorry about the broken link! I removed the one in cranelift and merged it with the wasmtime contributing docs. The top-level CONTRIBUTING.md is just a thin shim pointing to those docs. I figured there wasn't much use in having two CONTRIBUTING.md files, but I think it's fine for the README to point directly to the online docs!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 23 2020 at 16:58):

sunfishcode closed Issue #1280:

Probably got lost in the switch to wasmtime. cranelift/README.md links to cranelift/CONTRIBUTING.md, but there's no file there. Not sure whether you want this to link to CONTRIBUTING.md or something in cranelift/docs, so I didn't make a PR.

Last updated: Dec 23 2024 at 12:05 UTC