Stream: git-wasmtime

Topic: wasmtime / Issue #1259 [cranelift] Simplify SSABuilder wi...

Wasmtime GitHub notifications bot (Mar 09 2020 at 13:01):

Y-Nak opened Issue #1259:

Feature

Current implementation of SSABuilder has redundant fields and depends on redundant function/struct in order to work with EBB.
We no longer need them and can simplify SSABuilder when assuming all blocks are BasicBlock.

Benefit

Readability and (small) performance improvement.

Implementation

Remove extra fields and functions related to EBB.

Wasmtime GitHub notifications bot (Mar 10 2020 at 08:17):

Y-Nak edited Issue #1259:

Feature

Current implementation of SSABuilder has redundant fields and depends on redundant function/struct in order to work with EBB.
We no longer need them and can simplify SSABuilder when assuming all blocks are BasicBlock.

Benefit

Readability and (small) performance improvement.

Implementation

Remove extra fields and functions related to EBB from SSABuilder and FunctionBuilder.

Wasmtime GitHub notifications bot (Mar 10 2020 at 09:58):

Y-Nak edited Issue #1259:

Feature

Current implementation of SSABuilder has redundant fields and depends on redundant function/struct in order to work with EBB.
We no longer need them and can simplify SSABuilder when assuming all blocks are BasicBlock.

Benefit

Readability and (small) performance improvement.

Implementation

Remove extra fields and functions related to EBB from frontend/src/ssa.rs and frontend/src/frontend.rs.

Wasmtime GitHub notifications bot (Mar 10 2020 at 15:19):

Y-Nak commented on Issue #1259:

Draft proposal: https://github.com/Y-Nak/wasmtime/tree/simplify-ssa-builder

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:39):

bnjbvr commented on Issue #1259:

Thanks for opening an issue. We identified this simplification opportunity too with @eqrion, so it's definitely something we had in mind. Maybe @eqrion or I could do a proper review for this, if you wanted to submit a PR?

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:44):

Y-Nak commented on Issue #1259:

Thanks for responding back. I'll submit a PR.

Wasmtime GitHub notifications bot (Mar 17 2020 at 15:49):

Y-Nak edited a comment on Issue #1259:

Thanks for responding back! I'll submit a PR.

Wasmtime GitHub notifications bot (Mar 20 2020 at 18:54):

sunfishcode closed Issue #1259:

Feature

Current implementation of SSABuilder has redundant fields and depends on redundant function/struct in order to work with EBB.
We no longer need them and can simplify SSABuilder when assuming all blocks are BasicBlock.

Benefit

Readability and (small) performance improvement.

Implementation

Remove extra fields and functions related to EBB from frontend/src/ssa.rs and frontend/src/frontend.rs.

Last updated: Dec 23 2024 at 12:05 UTC