Stream: git-wasmtime

Topic: wasmtime / Issue #1255 [wasi-common]: move filetime modul...

Wasmtime GitHub notifications bot (Mar 08 2020 at 10:44):

kubkon commented on Issue #1255:

Big picture: Moving code like this into Yanix is great, because that makes it easy to share between WASI snapshot versions.

My thinking exactly!

Is it possible to remove the filetime dependency from wasi-common's Cargo.toml with this?

I thought about this exact thing and the answer is unfortunately no since filetime is a cross-platform crate (it's got bindings for Windows as well). We actually make use of filetime crate in cross-platform syscall implementation in wasi-common, whereas yanix provides only convenience wrappers for emulated utimensat syscall on platforms/kernels that don't support it. So long story short, no, we have to keep the dependency for now. The good news is, when I finally get round to backporting our modifications to the upstream filetime crate, we'll only be left with filetime as a dependency in wasi-common.

Last updated: Oct 23 2024 at 20:03 UTC