kubkon commented on Issue #1255:
Big picture: Moving code like this into Yanix is great, because that makes it easy to share between WASI snapshot versions.
My thinking exactly!
Is it possible to remove the
filetime
dependency from wasi-common's Cargo.toml with this?I thought about this exact thing and the answer is unfortunately no since
filetime
is a cross-platform crate (it's got bindings for Windows as well). We actually make use offiletime
crate in cross-platform syscall implementation inwasi-common
, whereasyanix
provides only convenience wrappers for emulatedutimensat
syscall on platforms/kernels that don't support it. So long story short, no, we have to keep the dependency for now. The good news is, when I finally get round to backporting our modifications to the upstreamfiletime
crate, we'll only be left withfiletime
as a dependency inwasi-common
.
Last updated: Dec 23 2024 at 12:05 UTC