Stream: git-wasmtime

Topic: wasmtime / Issue #1245 Remove duplicate code for mapping ...

Wasmtime GitHub notifications bot (Mar 06 2020 at 18:12):

abrown opened Issue #1245:

<!-- Please try to describe precisely what you would like to do in
Cranelift/Wasmtime and/or expect from it. You can answer the questions below if
they're relevant and delete this text before submitting. Thanks for opening an
issue! -->

Feature

<!-- What is the feature or code improvement you would like to do in
Cranelift/Wasmtime? -->

Remove the duplication of map_reg; it exists in both wasmtime-debug and cranelift-codegen.

Benefit

<!-- What is the value of adding this in Cranelift/Wasmtime? -->
Avoids duplicated code. See discussion in
https://github.com/bytecodealliance/wasmtime/commit/a9ca4c0f7b6e2db207acece2001b42b25efb08a0#r37665763 for context.

Implementation

<!-- Do you have an implementation plan, and/or ideas for data structures or
algorithms to use? -->

I think the best way to do this is likely to make map-reg public in cranelift-codegen and then re-publicize it through wasmtime-environ. wasmtime-debug already has a dependency on wasmtime-environ so this way we could reach map_reg and thus remove the duplicated map_reg in wasmtime-debug.

Alternatives

<!-- Have you considered alternative implementations? If so, how are they
better or worse than your proposal? -->

• As @iximeow mentioned, there may be a way to write a new struct to do the mapping from cranelift registers to gimli registers
• We could import cranelift-codegen into wasmtime-debug directly but the cranelift-codegen <- wasmtime-environ <- wasmtime-debug seems cleaner

Wasmtime GitHub notifications bot (Mar 06 2020 at 18:12):

abrown edited Issue #1245:

<!-- Please try to describe precisely what you would like to do in
Cranelift/Wasmtime and/or expect from it. You can answer the questions below if
they're relevant and delete this text before submitting. Thanks for opening an
issue! -->

Feature

<!-- What is the feature or code improvement you would like to do in
Cranelift/Wasmtime? -->

Remove the duplication of map_reg; it exists in both wasmtime-debug and cranelift-codegen.

Benefit

<!-- What is the value of adding this in Cranelift/Wasmtime? -->
Avoids duplicated code. See discussion in https://github.com/bytecodealliance/wasmtime/commit/a9ca4c0f7b6e2db207acece2001b42b25efb08a0#r37665763 for context.

Implementation

<!-- Do you have an implementation plan, and/or ideas for data structures or
algorithms to use? -->

I think the best way to do this is likely to make map-reg public in cranelift-codegen and then re-publicize it through wasmtime-environ. wasmtime-debug already has a dependency on wasmtime-environ so this way we could reach map_reg and thus remove the duplicated map_reg in wasmtime-debug.

Alternatives

<!-- Have you considered alternative implementations? If so, how are they
better or worse than your proposal? -->

• As @iximeow mentioned, there may be a way to write a new struct to do the mapping from cranelift registers to gimli registers
• We could import cranelift-codegen into wasmtime-debug directly but the cranelift-codegen <- wasmtime-environ <- wasmtime-debug seems cleaner

Wasmtime GitHub notifications bot (Mar 06 2020 at 18:14):

abrown assigned Issue #1245:

<!-- Please try to describe precisely what you would like to do in
Cranelift/Wasmtime and/or expect from it. You can answer the questions below if
they're relevant and delete this text before submitting. Thanks for opening an
issue! -->

Feature

<!-- What is the feature or code improvement you would like to do in
Cranelift/Wasmtime? -->

Remove the duplication of map_reg; it exists in both wasmtime-debug and cranelift-codegen.

Benefit

<!-- What is the value of adding this in Cranelift/Wasmtime? -->
Avoids duplicated code. See discussion in https://github.com/bytecodealliance/wasmtime/commit/a9ca4c0f7b6e2db207acece2001b42b25efb08a0#r37665763 for context.

Implementation

<!-- Do you have an implementation plan, and/or ideas for data structures or
algorithms to use? -->

I think the best way to do this is likely to make map-reg public in cranelift-codegen and then re-publicize it through wasmtime-environ. wasmtime-debug already has a dependency on wasmtime-environ so this way we could reach map_reg and thus remove the duplicated map_reg in wasmtime-debug.

Alternatives

<!-- Have you considered alternative implementations? If so, how are they
better or worse than your proposal? -->

• As @iximeow mentioned, there may be a way to write a new struct to do the mapping from cranelift registers to gimli registers
• We could import cranelift-codegen into wasmtime-debug directly but the cranelift-codegen <- wasmtime-environ <- wasmtime-debug seems cleaner

Wasmtime GitHub notifications bot (Mar 31 2020 at 22:42):

abrown closed Issue #1245 (assigned to abrown):

<!-- Please try to describe precisely what you would like to do in
Cranelift/Wasmtime and/or expect from it. You can answer the questions below if
they're relevant and delete this text before submitting. Thanks for opening an
issue! -->

Feature

<!-- What is the feature or code improvement you would like to do in
Cranelift/Wasmtime? -->

Remove the duplication of map_reg; it exists in both wasmtime-debug and cranelift-codegen.

Benefit

<!-- What is the value of adding this in Cranelift/Wasmtime? -->
Avoids duplicated code. See discussion in https://github.com/bytecodealliance/wasmtime/commit/a9ca4c0f7b6e2db207acece2001b42b25efb08a0#r37665763 for context.

Implementation

<!-- Do you have an implementation plan, and/or ideas for data structures or
algorithms to use? -->

I think the best way to do this is likely to make map-reg public in cranelift-codegen and then re-publicize it through wasmtime-environ. wasmtime-debug already has a dependency on wasmtime-environ so this way we could reach map_reg and thus remove the duplicated map_reg in wasmtime-debug.

Alternatives

<!-- Have you considered alternative implementations? If so, how are they
better or worse than your proposal? -->

• As @iximeow mentioned, there may be a way to write a new struct to do the mapping from cranelift registers to gimli registers
• We could import cranelift-codegen into wasmtime-debug directly but the cranelift-codegen <- wasmtime-environ <- wasmtime-debug seems cleaner

Last updated: Dec 23 2024 at 12:05 UTC