Stream: git-wasmtime

Topic: wasmtime / Issue #1242 [wasi-common]: yanix now returns i...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 14:38):

kubkon commented on Issue #1242:

I was thinking the same thing! And I think we can it one step further too. Yanix started with a fair amount of EOVERFLOW checking, which is a good default stance in wasi-common because we convert a lot of host values into wasm32 values, however Yanix has now established itself as a library that just provides host functionality, without any wasm32-specific type conversions. So I went through this PR, and convinced myself that every single EOVERFLOW is either unneeded or we can do something else.

Hooray! Let me make adjustments then!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 15:53):

kubkon commented on Issue #1242:

@sunfishcode comments addressed in ad6e7ab!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 06 2020 at 21:30):

kubkon commented on Issue #1242:

@sunfishcode Lemme know if this looks ready for you, and we can merge. :-)

Last updated: Nov 22 2024 at 16:03 UTC