github-actions[bot] commented on Issue #1223:
Subscribe to Label Action
This issue or pull request has been labeled: "c", "r", "a", "n", "e", "l", "i", "f", "t"
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
github-actions[bot] commented on Issue #1223:
Subscribe to Label Action
This issue or pull request has been labeled: "c", "r", "a", "n", "e", "l", "i", "f", "t"
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
github-actions[bot] commented on Issue #1223:
Subscribe to Label Action
This issue or pull request has been labeled: "c", "r", "a", "n", "e", "l", "i", "f", "t"
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
github-actions[bot] commented on Issue #1223:
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift"
<details> <summary>Users Subscribed to "cranelift"</summary>
- @bnjbvr
</details>
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
abrown commented on Issue #1223:
@bnjbvr, I think is ready for another review but it would be best if we took a look at #1517 first since this uses some of the changes that PR made to
RunCommand
.
bnjbvr commented on Issue #1223:
Sorry, I am swamped in reviews again, and I don't know when I'd be able to do this; forwarding to other people.
abrown commented on Issue #1223:
Stuff I'm going to make a note to work on later:
- a Trap variant for unknown opcodes instead of using
unimplemented!
, from @fitzgen- convert the
block()
method to use a loop instead of recursing, from @bnjbvr- think about renaming
Frame
andEnvironment
, from a comment to @fitzgen
Last updated: Dec 23 2024 at 13:07 UTC