Stream: git-wasmtime

Topic: wasmtime / Issue #1215 Missing define/undef of 'own' symb...

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 19:52):

alexcrichton commented on Issue #1215:

I believe this was fixed in https://github.com/bytecodealliance/wasmtime/pull/1286, and we're not verifying the header file is usable on CI!

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 19:52):

alexcrichton closed Issue #1215:

#define own
and
#undef own

are missing for new wasmtime.h.

Both wasi.h and wasm.h define own properly.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 19:56):

rene-fonseca commented on Issue #1215:

Yes, fixed now.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 19:58):

rene-fonseca commented on Issue #1215:

Oh I still like the #include <wasm.h> changed though - see above.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 20:10):

alexcrichton commented on Issue #1215:

Can you open a separate issue? It's hard to dig through the comments of an unrelated issue to see what needs fixing.

view this post on Zulip Wasmtime GitHub notifications bot (Mar 13 2020 at 20:14):

rene-fonseca commented on Issue #1215:

Opened https://github.com/bytecodealliance/wasmtime/issues/1313

Last updated: Nov 22 2024 at 16:03 UTC