Stream: git-wasmtime

Topic: wasmtime / Issue #1202 It's wiggle time!

Wasmtime GitHub notifications bot (Mar 12 2020 at 17:17):

github-actions[bot] commented on Issue #1202:

Subscribe to Label Action

This issue or pull request has been labeled: "w", "a", "s", "i"

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.

Wasmtime GitHub notifications bot (Mar 19 2020 at 18:38):

kubkon commented on Issue #1202:

OK, I'm marking this as ready for review. Here's the summary of changes:

This is a rather massive commit that introduces `wiggle` into the
picture. We still use `wig`'s macro in `old` snapshot and to generate
`wasmtime-wasi` glue, but everything else is now autogenerated by `wiggle`.
In summary, thanks to `wiggle`, we no longer need to worry about
serialising and deserialising to and from the guest memory, and
all guest (WASI) types are now proper idiomatic Rust types.

While we're here, in preparation for the ephemeral snapshot, I went
ahead and reorganised the internal structure of the crate. Instead of
modules like `hostcalls_impl` or `hostcalls_impl::fs`, the structure
now resembles that in ephemeral with modules like `path`, `fd`, etc.
Now, I'm not requiring we leave it like this, but I reckon it looks
cleaner this way after all.

Wasmtime GitHub notifications bot (Mar 19 2020 at 20:19):

kubkon commented on Issue #1202:

@pchickey I've now re-used contains for flags wherever possible. It should read much better now, I reckon :-)

Wasmtime GitHub notifications bot (Mar 20 2020 at 00:38):

sunfishcode commented on Issue #1202:

Just a quick note -- there are a bunch of references to FdEntry in comments still in the tree that would be good to update to Entry.

Wasmtime GitHub notifications bot (Mar 20 2020 at 09:00):

kubkon commented on Issue #1202:

Just a quick note -- there are a bunch of references to FdEntry in comments still in the tree that would be good to update to Entry.

Thanks for the heads up! I have to admit, I've not paid too much attention to the docs yet.

Wasmtime GitHub notifications bot (Mar 20 2020 at 15:03):

alexcrichton commented on Issue #1202:

I'm curious what the story is for the old snapshot? It's already been somewhat painful when the two snapshots diverge in how they're defined idiomatically. Is the intention to migrate the old snapshot? Implement the old snapshot trait for the same WasiCtx type? Never migrate?

Wasmtime GitHub notifications bot (Mar 20 2020 at 15:06):

kubkon commented on Issue #1202:

I'm curious what the story is for the old snapshot? It's already been somewhat painful when the two snapshots diverge in how they're defined idiomatically. Is the intention to migrate the old snapshot? Implement the old snapshot trait for the same WasiCtx type? Never migrate?

So the current idea is to only migrate latest to wiggle, while the old snapshot will get polyfilled once we figure out how to do it using wiggle. This way, we hope to reduce the duplication to a bare minimum. For ref, see #1252.

Wasmtime GitHub notifications bot (Mar 20 2020 at 17:10):

kubkon commented on Issue #1202:

Hmm, not sure why building the book suddenly failed :thinking:

Wasmtime GitHub notifications bot (Mar 20 2020 at 17:14):

alexcrichton commented on Issue #1202:

Oh the book build is my fault

Last updated: Dec 23 2024 at 12:05 UTC