Stream: git-wasmtime

Topic: wasmtime / Issue #1144 Integrate clippy checking in CI build

Wasmtime GitHub notifications bot (Mar 25 2020 at 13:36):

marmistrz commented on Issue #1144:

I think it would be nice to have selected checks enforced on the CI.

For instance, I frequently encounter the "unnecessary name repetition" lint failing in the codebase and I think it would be a good idea. On the other hand, this should be definitely a whitelist of curated checks and not a wholesale inclusion of clippy.

Is there any reason why we have to use clippy check from actions-rs and not just manually install it with rustup and execute cargo clippy inside the CI?

Wasmtime GitHub notifications bot (Mar 25 2020 at 14:19):

bjorn3 commented on Issue #1144:

The actions-rs version shows annotations on pull requests for all warnings and errors, while just using cargo clippy requires you to visit the build log.

Wasmtime GitHub notifications bot (Mar 25 2020 at 14:22):

bjorn3 edited a comment on Issue #1144:

The actions-rs version shows annotations on pull requests for all warnings and errors, while just using cargo clippy requires you to visit the build log.

Edit: Doesn't work for pull requests from forks due to permission problems.

Last updated: Nov 22 2024 at 16:03 UTC