Stream: git-wasmtime

Topic: wasmtime / Issue #1135 Verify immediate and value types a...

Wasmtime GitHub notifications bot (Feb 03 2021 at 18:21):

bjorn3 commented on Issue #1135:

The new backend framework doesn't use legalizations as much as the old backend framework anymore.

Wasmtime GitHub notifications bot (Feb 03 2021 at 18:29):

abrown closed Issue #1135:

In bytecodealliance/cranelift#1012 I noticed that that when we bind a type or immediate to an instruction (e.g. .bind(I32)), we don't verify that they are valid. I believe this happens at some later time but it would be more comprehensible to the user if the error was thrown closer to where they wrote the bind code.

Secondly, I did not see that the order of value types and immediates is checked, so the bind calls could be mixed in some nonsensical order (to the user) that ends up working correctly during codegen. This could be fixed by storing all of the bound parameters together in a single vector instead of separate vectors for value types and immediates.

Last updated: Nov 22 2024 at 16:03 UTC