Alex Crichton (May 19 2020 at 02:32): Alex Crichton (May 19 2020 at 02:32):One thought I just had, @Yury Delendik what would you think of merging the wasmparser, wat, and wasmprinter repos? They sort of all change in lockstep anyway and it'd make it a lot easier to do sweeping changes (like implementing new proposals)
Alex Crichton (May 19 2020 at 02:33):It could be a general "low level wasm tooling in that place" perhaps, not a home for something higher level like walrus
Yury Delendik (May 19 2020 at 13:34):I had that thought as well. That's okay with me. What will be a repo name?
Alex Crichton (May 19 2020 at 14:01):hm I hadn't thought that far, we could also do something bland like "wasm-tooling"
Yury Delendik (May 19 2020 at 14:09):okay. I don't know what involved in merging two repos, but first step can be moving wasmparser into bytecodealliance/wat
Yury Delendik (May 19 2020 at 14:10):there are not many issues opened with wasmparser -- I assume it is easy to move them by hand if needed
Alex Crichton (May 19 2020 at 14:11):yeah these are all pretty small
Alex Crichton (May 19 2020 at 14:11):@fitzgen (he/him) do you have thoughts on this perhaps?
Till Schneidereit (May 19 2020 at 14:14):I think this is a good idea, fwiw!
fitzgen (he/him) (May 19 2020 at 15:12):Yeah sounds good. Maybe we could call it WART: web assembly rust toolkit :joy:
fitzgen (he/him) (May 19 2020 at 15:13):Or maybe bugs, as in bugs bunny, to go along with WABT
fitzgen (he/him) (May 19 2020 at 15:13):But yeah the one thing missing is a wasm binary encoder
fitzgen (he/him) (May 19 2020 at 15:14):Which we could extract from walrus sometime
Yury Delendik (May 19 2020 at 15:15):keep it wat, as in WebAssembly Toolkit ?
fitzgen (he/him) (May 19 2020 at 15:17):We are just naming the repo, right? Not renaming or merging the crates themselves, which are just moving?
fitzgen (he/him) (May 19 2020 at 15:17):If so, wat could be confusing since one of the crates has that name
fitzgen (he/him) (May 19 2020 at 15:18):Mostly I was joking with the names, and I agree a boring name like wasm-tools or something is a good fit
Alex Crichton (May 19 2020 at 16:18):yeah I'm not thinking we should reorganize the crates at all, just merge repos
Alex Crichton (May 19 2020 at 16:18):and update test suites so they're all referential
Alex Crichton (May 19 2020 at 16:19):ok so how about bytecodealliance/wasm-tools
Alex Crichton (May 19 2020 at 16:19):and a top-level crate that has src/bin/*.rs for things like wasm2wat and whatnot (probably with a -rs suffix or something like that)
Alex Crichton (May 19 2020 at 16:19):and crates/{wasmparser,wasmprinter,wat,wast} ?
Alex Crichton (May 19 2020 at 16:19):I can prep the repo if that sounds good
fitzgen (he/him) (May 19 2020 at 17:37):@Alex Crichton sounds great!
Alex Crichton (May 19 2020 at 21:32):@fitzgen (he/him) @Yury Delendik WDYT? https://github.com/bytecodealliance/wasm-tools
fitzgen (he/him) (May 19 2020 at 21:35):looks great!
Yury Delendik (May 19 2020 at 21:36):wfm, what about history?
Alex Crichton (May 19 2020 at 21:38):That repo is currently created by literally using git merge between the all repos
Alex Crichton (May 19 2020 at 21:38):so the history for each repo should be there
Alex Crichton (May 19 2020 at 21:38):with one commit per repo to move everything to a sub-folder
Yury Delendik (May 19 2020 at 21:38):okay, I see, it is just github
Alex Crichton (May 19 2020 at 21:41):I tried to do my best when unifying the test suite
Alex Crichton (May 19 2020 at 21:41):the tests/roundtrip.rs script is pretty gnarly though
Alex Crichton (May 19 2020 at 21:41):it's not entirely trivial to run all the wast tests
Alex Crichton (May 19 2020 at 21:41):esp when we're juggling different implementation levels for various proposals across all the tools
Alex Crichton (May 19 2020 at 22:00):ok I'll pull the trigger on this tomorrow unless an objection comes up?
Yury Delendik (May 19 2020 at 22:05):Do we want to open issue(s) with announcement on merged repos?
Alex Crichton (May 19 2020 at 22:05):What I'd imagine is similar to cranelift, which is to transfer all active issues as well as leaving a comment on open PRs
Alex Crichton (May 19 2020 at 22:06):and otherwise updating the master branch to say it points elsewhere
Alex Crichton (May 19 2020 at 22:06):I'd probably immediately read-only the wat/wasmprinter repos since they don't have open PRs
Alex Crichton (May 19 2020 at 22:06):and we could read-only wasmparser eventually once prs have moved
Alex Crichton (May 19 2020 at 22:06):er, read-only being "archive"
Alex Crichton (May 20 2020 at 14:49):ok I'm pulling the trigger
Yury Delendik (May 20 2020 at 18:21):@Alex Crichton will you publish new versions of wasmparser? or what is the process?
Alex Crichton (May 20 2020 at 18:21):nah I think it's fine to do what you did before
Alex Crichton (May 20 2020 at 18:21):basically just push a commit with a version and hit publish
Alex Crichton (May 20 2020 at 18:21):although there's no need to publish the tail call stuff
Alex Crichton (May 20 2020 at 18:21):I'm just trying to get wat/wasmparser on parity
Alex Crichton (May 20 2020 at 18:21):and get wasmparser pass the current set of spec tests
Yury Delendik (May 20 2020 at 18:22):but it triggers version change
Yury Delendik (May 20 2020 at 18:22):shall we ensure version change goes into PR?
Alex Crichton (May 20 2020 at 18:23):personally I take a look at the changes when publishing a version
Alex Crichton (May 20 2020 at 18:23):so I leave it as-is in the repo until I publish
Yury Delendik (May 20 2020 at 18:23):okay
Alex Crichton (May 20 2020 at 18:23):then when publishing I reverse-engineer whether a bump should happen or not
Alex Crichton (May 20 2020 at 18:23):although I wouldn't say it's a great system
Last updated: Dec 23 2024 at 13:07 UTC