Stream: wasm

Topic: ModuleResources and wasmparser

Alex Crichton (Jul 21 2020 at 15:34):

@Yury Delendik would you be able to give me some back story about ModuleResources in wasmparser?

Alex Crichton (Jul 21 2020 at 15:34):

I'm curious if we can remove that trait now with a more flexible Validator

Yury Delendik (Jul 21 2020 at 15:36):

Mostly to decouple a module and function validators. Also, delay function validation until needed.

Alex Crichton (Jul 21 2020 at 15:37):

is there a need for it to be a trait though?

Alex Crichton (Jul 21 2020 at 15:37):

in terms of having external implementors?

Alex Crichton (Jul 21 2020 at 15:37):

or could we perhaps create a FuncValidator::new or something like that?

Yury Delendik (Jul 21 2020 at 15:38):

So in theory, before, you could validate everything in the module except functions

Alex Crichton (Jul 21 2020 at 15:39):

oh right this makes sense as a functionality thing, was wondering if there was a reason specifically for it to be a trait

Yury Delendik (Jul 21 2020 at 15:39):

to provide context to function validator, you needed some object and ModuleResources was it
it does not have to be a trait

Alex Crichton (Jul 21 2020 at 15:39):

ok makes sense

Alex Crichton (Jul 21 2020 at 15:40):

thanks!

Last updated: Dec 23 2024 at 12:05 UTC