Yury Delendik (Jul 09 2020 at 17:15): Yury Delendik (Jul 09 2020 at 17:15):@Alex Crichton I'm looking at https://github.com/bytecodealliance/wasm-tools/pull/37 . We are trying to preserve names in the inlined modules. Does it even make sense to have names in the binary format? We rely on right order anyway.
Alex Crichton (Jul 09 2020 at 17:16):@Yury Delendik hm which names are you referring to?
Yury Delendik (Jul 09 2020 at 17:17):that are used in imports_equal and exports_equal
Alex Crichton (Jul 09 2020 at 17:18):that's... a good point
Alex Crichton (Jul 09 2020 at 17:18):you mean like the type definition doesn't need the name at all?
Yury Delendik (Jul 09 2020 at 17:19):right, wondering where else we are using names for inlined modules externals
Alex Crichton (Jul 09 2020 at 17:19):I think you're right that we never use them
Alex Crichton (Jul 09 2020 at 17:19):they're always referred to positionally or by index
Alex Crichton (Jul 09 2020 at 17:19):I'll file an issue on the upstream spec and/or raise this
Alex Crichton (Jul 09 2020 at 17:51):@Yury Delendik actually thinking more on this I think it's relevant for subtyping
Alex Crichton (Jul 09 2020 at 17:51):b/c it allows you do declare a different order for exports than the submodule, but they can be lined up still
Yury Delendik (Jul 09 2020 at 17:53):Does it affect the PR validation logic in some way?
Alex Crichton (Jul 09 2020 at 19:10):@Yury Delendik oh not the PR itself, this is relevant for submodule testing already in wasmparser at this point
Alex Crichton (Jul 09 2020 at 19:10):er, subtype testing*
Last updated: Oct 23 2024 at 20:03 UTC