@Alex Crichton I'm looking at https://github.com/bytecodealliance/wasm-tools/pull/37 . We are trying to preserve names in the inlined modules. Does it even make sense to have names in the binary format? We rely on right order anyway.
@Yury Delendik hm which names are you referring to?
that are used in imports_equal
and exports_equal
that's... a good point
you mean like the type definition doesn't need the name at all?
right, wondering where else we are using names for inlined modules externals
I think you're right that we never use them
they're always referred to positionally or by index
I'll file an issue on the upstream spec and/or raise this
@Yury Delendik actually thinking more on this I think it's relevant for subtyping
b/c it allows you do declare a different order for exports than the submodule, but they can be lined up still
Does it affect the PR validation logic in some way?
@Yury Delendik oh not the PR itself, this is relevant for submodule testing already in wasmparser at this point
er, subtype testing*
Last updated: Dec 23 2024 at 13:07 UTC