Stream: wasi

Topic: wasi-nn missing_memory errno


view this post on Zulip Pat Hickey (Jan 06 2021 at 19:02):

https://github.com/bytecodealliance/wasmtime/pull/2549/ removes the need for wasi-nn to have a $missing_memory variant in the errno type

The missing memory behavior was always a silly thing that was created long ago because I didn't understand the wasmtime API very well. Instead of creating a weird warning and returning an error...

view this post on Zulip Pat Hickey (Jan 06 2021 at 19:03):

should i make a PR to remove it from the spec as well?

view this post on Zulip Pat Hickey (Jan 06 2021 at 19:05):

im not sure what all the follow-on effects of removing that variant are, since it will change the numbering of errno::busy

view this post on Zulip Pat Hickey (Jan 06 2021 at 19:05):

and im not sure of all the spots that depend on it are, and if theyre code generated etc

view this post on Zulip Andrew Brown (Jan 06 2021 at 21:04):

I think that PR makes sense

view this post on Zulip Andrew Brown (Jan 06 2021 at 21:04):

(also not exactly sure of the ramifications but I will test it out before I bump the wasi-nn spec submodule commit)


Last updated: Dec 23 2024 at 12:05 UTC