John Ericson (Mar 21 2022 at 22:08): John Ericson (Mar 21 2022 at 22:08):OK last thing, the windows tests fail. But it never set WASM_CC on windows. I am trying unset CC and if that doens't work, I will just do CC=clang, and then it will work.
John Ericson (Mar 21 2022 at 22:09):(The problem is that CC=cc in the windows env, so CC ?= clang didn't kick in whereas WASM_CC ?= clang did.
John Ericson (Mar 21 2022 at 22:10):Error: Invalid environment variable format 'unset CC'
John Ericson (Mar 21 2022 at 22:10):OK so plan B, will push again in a few second.
Dan Gohman (Mar 21 2022 at 22:10):/me gives Windows a sideways glance
John Ericson (Mar 21 2022 at 22:11):I bet they all had CC=cc, to begin with, but the others were setting CC / WASM_CC already.
John Ericson (Mar 21 2022 at 22:16):I see the mac error. I am going to check github docs to see if it is just possible to start with a blanket set of env vars
John Ericson (Mar 21 2022 at 22:24):That doesn't appear to exist lol https://stackoverflow.com/questions/70137245/how-to-remove-an-environment-variable-on-github-actions yay ambient authority "just ignore the env vars you don't care about, what's the problem?!"
John Ericson (Mar 21 2022 at 22:25):OK @Dan Gohman one more push
John Ericson (Mar 21 2022 at 22:25):oh you are really fast or I am slow :)
John Ericson (Mar 21 2022 at 22:25):it's running
Dan Gohman (Mar 21 2022 at 22:37):I don't quite understand your last comment
John Ericson (Mar 21 2022 at 22:38):I thought you had to approve me each time. And I either i was wrong about that, or you are doing it really fast :)
John Ericson (Mar 21 2022 at 22:38):undefinod-symbols.txt is in the macOS CI. WTF. Bad flash or memory?
John Ericson (Mar 21 2022 at 22:41):I didn't make that typo according to git on my end!
Dan Gohman (Mar 21 2022 at 22:44):woah... "undefinod" is coming from nowhere?
Dan Gohman (Mar 21 2022 at 22:46):I'm rerunning that job to see if it was somehow a spurious failure
Dan Gohman (Mar 21 2022 at 22:46):But that's really bizarre
Dan Gohman (Mar 21 2022 at 22:47):(also, yes, I was just clicking the button fast :-))
John Ericson (Mar 21 2022 at 22:49):I think this might be the first time in my life I hit some corrupted memory! Unless it was a macOS file system bug.
Dan Gohman (Mar 21 2022 at 22:54):Looks like it failed again, the same way?
John Ericson (Mar 21 2022 at 22:57):Huh. Well I just pushed a new version tweaking Windows CI a a bit. Curious after the files are modified a bit (just to shuffle things around) we still get this issue.
John Ericson (Mar 21 2022 at 23:18):https://github.com/WebAssembly/wasi-libc/pull/273 I decided to just split up the PR to bisect this bug
John Ericson (Mar 21 2022 at 23:18):(or do something more different to try to avoid this corruption!)
John Ericson (Mar 21 2022 at 23:39):https://github.com/WebAssembly/wasi-libc/pull/274 another one
Last updated: Oct 23 2024 at 20:03 UTC