Stream: wasi

Topic: landing wiggle in wasmtime

view this post on Zulip Pat Hickey (Mar 11 2020 at 02:31):

@Dan Gohman @Alex Crichton @Jakub Konka how do y'all feel about a PR that lands wiggle (and its subcrates) into the wasmtime repository, so we can publish a crates.io release as part of an ordinary wasmtime release?

view this post on Zulip Pat Hickey (Mar 11 2020 at 02:32):

i know the PR to use wiggle in wasi-common is still not quite done, and im keen to pitch in on that, but in the meantime it would be useful to me to have a crates.io release to point my lucet integration at. (presently just using a git dependency)

view this post on Zulip Jakub Konka (Mar 11 2020 at 07:36):

Makes sense to me! Lemme quickly come up with such a PR! Oh, like with migrating wasi-common and cranelift, I’ll preserve the git history for posterity if for nothing else.

view this post on Zulip Jakub Konka (Mar 11 2020 at 09:58):

Waiting for your review guys: https://github.com/bytecodealliance/wasmtime/pull/1278

[wasi-common]: Hello wiggle! by kubkon · Pull Request #1278 · bytecodealliance/wasmtime
Hello wiggle! This PR migrates wiggle to crates/wasi-common/wiggle as a subdir of wasmtime monorepo. I've strived to preserve all wiggle's git history. All I've done so far in this PR i...

view this post on Zulip Alex Crichton (Mar 11 2020 at 13:08):

Sounds reasonable to me!

view this post on Zulip Jakub Konka (Mar 11 2020 at 13:40):

In preparation for landing #1278, I've now made wiggle repo read-only

view this post on Zulip Pat Hickey (Mar 11 2020 at 16:25):

My one bit of feedback is we should put it at crates/wiggle. I think (hope?) we get lots of use outside of wasi-common :)

view this post on Zulip Jakub Konka (Mar 11 2020 at 16:28):

SGTM! Should be pretty easy to fix in the PR!

view this post on Zulip Dan Gohman (Mar 11 2020 at 16:29):

On a similar note, I expect we'll eventually want to move yanix/winx out to crates/ at some point too.

view this post on Zulip Jakub Konka (Mar 11 2020 at 16:37):

Yep, figured as much ;-)

view this post on Zulip Jakub Konka (Mar 11 2020 at 16:37):

Pat Hickey said:

My one bit of feedback is we should put it at crates/wiggle. I think (hope?) we get lots of use outside of wasi-common :)

And done :-)

view this post on Zulip Jakub Konka (Mar 11 2020 at 17:02):

While we're here, do you think we should split tests in the CI into something that's more context oriented? Separately running tests for WASI and related, wiggle, etc? I feel currently it's quite difficulty to work out what is going on in the CI

view this post on Zulip Jakub Konka (Mar 11 2020 at 17:13):

Exciting times ahead, wiggle just landed ;-)

view this post on Zulip Dan Gohman (Mar 11 2020 at 17:22):

:wavy_dash:️It's Wiggle Time:wavy_dash:️

view this post on Zulip Jakub Konka (Mar 11 2020 at 17:26):

This will never get old :D

Last updated: Dec 23 2024 at 12:05 UTC