GitHub (Dec 19 2019 at 17:18): GitHub (Dec 19 2019 at 17:18):yurydelendik created PR Review Comment:
@yurydelendik would cranelift-module be a useful place to share this logic translating FrameLocationChange to CFI instructions for your use in wasmtime?
@iximeow yes, and in fact, I would like to have entire cratelift-module change for other reasons.
GitHub (Dec 19 2019 at 17:18):yurydelendik submitted PR Review.
GitHub (Jan 18 2020 at 01:20):iximeow updated PR #902 from framechange_eh_frame_support to master:
This teaches
cranelift-faeriehow to write.eh_framesections that are appropriate with respect to call frames for functions that produce layout information.This builds quite directly on https://github.com/CraneStation/cranelift/pull/679, which is still open, and whose changes are alongside this as a result. For the time being, my changes on top of @yurydelendik 's PR are best seen as a diff between our branches.
Being dependent on an already-floating PR, I want to mostly call attention to the points that:
- frame change information is useful for handling unwinding as @bjorn3 mentioned here
- consumers of Cranelift (in this case, Lucet) probably want to unwind through Cranelift-generated code
- #679 is good enough to build on to the above ends, and the changes to produce .eh_frame and support unwinding through Cranelift-generated code are fairly small.
I do have some comments in-line in case any readers do take a closer look at the changes here, but I'm not sure it makes sense to sweat the details until #679 is figured out, since it seems like we've bitrotted with respect to today's
masteranyway.
GitHub (Mar 03 2020 at 21:26):iximeow closed without merge PR #902.
Last updated: Nov 22 2024 at 16:03 UTC