Stream: git-cranelift

Topic: cranelift / PR #902 FrameLayoutChange-based .eh_frame sup...


view this post on Zulip GitHub (Dec 19 2019 at 17:18):

yurydelendik created PR Review Comment:

@yurydelendik would cranelift-module be a useful place to share this logic translating FrameLocationChange to CFI instructions for your use in wasmtime?

@iximeow yes, and in fact, I would like to have entire cratelift-module change for other reasons.

view this post on Zulip GitHub (Dec 19 2019 at 17:18):

yurydelendik submitted PR Review.

view this post on Zulip GitHub (Jan 18 2020 at 01:20):

iximeow updated PR #902 from framechange_eh_frame_support to master:

This teaches cranelift-faerie how to write .eh_frame sections that are appropriate with respect to call frames for functions that produce layout information.

This builds quite directly on https://github.com/CraneStation/cranelift/pull/679, which is still open, and whose changes are alongside this as a result. For the time being, my changes on top of @yurydelendik 's PR are best seen as a diff between our branches.

Being dependent on an already-floating PR, I want to mostly call attention to the points that:

I do have some comments in-line in case any readers do take a closer look at the changes here, but I'm not sure it makes sense to sweat the details until #679 is figured out, since it seems like we've bitrotted with respect to today's master anyway.

view this post on Zulip GitHub (Mar 03 2020 at 21:26):

iximeow closed without merge PR #902.


Last updated: Dec 23 2024 at 14:03 UTC