Stream: git-cranelift

Topic: cranelift / PR #1410 Allow modules to have names of arbit...

GitHub (Feb 27 2020 at 20:11):

jyn514 opened PR #1410 from byte-builder to master:

• [x] This has been discussed in issue #..., or if not, please tell us why
  here.

This is a minor change and is backwards compatible.

• [ ] A short description of what this does, why it is needed; if the
  description becomes long, the matter should probably be discussed in an issue
  first.

This is useful for me because I name the module after the file, which
comes from the filesystem and may not be valid UTF8.

Also, this removes a needless copy in ObjectBackend::new (.to_vec() copies the slice).

• [ ] This PR contains test cases, if meaningful.

N/A

• [ ] A reviewer from the core maintainer team has been assigned for this PR.
  If you don't know who could review this, please indicate so and/or ping
  bnjbvr. The list of suggested reviewers on the right can help you.

r? @philipc

GitHub (Feb 27 2020 at 21:34):

philipc submitted PR Review.

GitHub (Feb 27 2020 at 21:43):

iximeow submitted PR Review.

GitHub (Feb 27 2020 at 21:45):

iximeow merged PR #1410.

Last updated: Nov 22 2024 at 17:03 UTC