GitHub (Feb 13 2020 at 08:01): GitHub (Feb 13 2020 at 08:01):fitzgen requested eqrion for a review on PR #1389.
GitHub (Feb 13 2020 at 08:01):fitzgen opened PR #1389 from passive-elems-and-passive-data to master:
[X] This has been discussed in issue https://github.com/bytecodealliance/wasmtime/issues/928
[X] A short description of what this does, why it is needed; if the
description becomes long, the matter should probably be discussed in an issue
first.This is part of the bulk memory and reference types proposals.
[X] This PR contains test cases, if meaningful.
[X] A reviewer from the core maintainer team has been assigned for this PR.
If you don't know who could review this, please indicate so and/or ping
bnjbvr. The list of suggested reviewers on the right can help you.<!-- Please ensure all communication adheres to the code of conduct. -->
GitHub (Feb 14 2020 at 18:54):eqrion submitted PR Review.
GitHub (Feb 14 2020 at 18:54):eqrion created PR Review Comment:
What's idiomatic rust for unused function arguments? In
dummy.rsI see unused function arguments prefixed with_, and here we're adding a_use inside of the function def. I'm fine with either, but would prefer it to be consistent.
GitHub (Feb 14 2020 at 18:58):eqrion submitted PR Review.
GitHub (Feb 14 2020 at 19:04):bjorn3 submitted PR Review.
GitHub (Feb 14 2020 at 19:04):bjorn3 created PR Review Comment:
Prefixing the argument with
_is the most common. (I haven't every seen it this way :) )
GitHub (Feb 15 2020 at 22:52):fitzgen submitted PR Review.
GitHub (Feb 15 2020 at 22:52):fitzgen created PR Review Comment:
It is true that one would usually use
_prefix, but because it is in a trait method's default implementation, that underscore would become part of the variable names in the auto-generated rustdocs. The separate underscore is to avoid underscore-prefixed variable names in the rustdocs.
GitHub (Feb 15 2020 at 22:53):fitzgen merged PR #1389.
Last updated: Nov 22 2024 at 17:03 UTC